From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>,
"Di, ChenxuX" <chenxux.di@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix device hotplug remove
Date: Tue, 5 Nov 2019 13:54:46 +0000 [thread overview]
Message-ID: <b47b7dc1-7f71-9d24-8e06-cf41e5fc9f99@intel.com> (raw)
In-Reply-To: <F5DF4F0E3AFEF648ADC1C3C33AD4DBF17A56B4AC@SHSMSX101.ccr.corp.intel.com>
On 10/28/2019 5:51 AM, Yang, Qiming wrote:
> Hi,
>
>> -----Original Message-----
>> From: Di, ChenxuX
>> Sent: Thursday, October 24, 2019 9:03 AM
>> To: dev@dpdk.org
>> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Yang, Qiming
>> <qiming.yang@intel.com>; Di, ChenxuX <chenxux.di@intel.com>
>> Subject: [PATCH] app/testpmd: fix device hotplug remove
>>
>> Hotplug remove cause infinite loops. Fix by canceling port_close before
>> port_detach function when rmv_port_callback.
>>
>> Fixes: ac89d46096d5 ("net/i40e: release port upon close")
>>
>> Signed-off-by: Di ChenxuX <chenxux.di@intel.com>
>> ---
>> app/test-pmd/testpmd.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
>> 5701f3141..a264644a1 100644
>> --- a/app/test-pmd/testpmd.c
>> +++ b/app/test-pmd/testpmd.c
>> @@ -2708,7 +2708,6 @@ rmv_port_callback(void *arg)
>> no_link_check = 1;
>> stop_port(port_id);
>> no_link_check = org_no_link_check;
>> - close_port(port_id);
>> detach_port_device(port_id);
>> if (need_to_start)
>> start_packet_forwarding(0);
>> --
>> 2.17.1
>
> NACK, this patch is not acceptable.
>
I can't really follow what is the root cause of the failure here, @Qiming, if it
is a driver issue, can you please briefly describe what is wrong in the driver?
Thanks,
ferruh
next prev parent reply other threads:[~2019-11-05 13:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 1:03 Di ChenxuX
2019-10-24 11:28 ` Iremonger, Bernard
2019-10-24 17:24 ` Ferruh Yigit
2019-10-25 1:48 ` Di, ChenxuX
2019-10-27 22:35 ` Thomas Monjalon
2019-10-29 12:13 ` Ferruh Yigit
2019-10-28 5:51 ` Yang, Qiming
2019-11-05 13:54 ` Ferruh Yigit [this message]
2019-11-05 23:30 ` Ye Xiaolong
2019-11-06 5:08 ` [dpdk-dev] [PATCH v2] net/i40e: " Di ChenxuX
2019-11-07 2:50 ` Ye Xiaolong
2019-11-07 3:00 ` Di, ChenxuX
2019-11-07 3:11 ` Ye Xiaolong
2019-11-07 5:45 ` Di, ChenxuX
2019-11-07 5:45 ` Ye Xiaolong
2019-11-07 6:02 ` Di, ChenxuX
2019-11-07 6:23 ` [dpdk-dev] [PATCH v3] " Di ChenxuX
2019-11-11 8:42 ` Ye Xiaolong
2019-11-12 5:56 ` [dpdk-dev] [PATCH v4] " Di ChenxuX
2019-11-13 2:11 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b47b7dc1-7f71-9d24-8e06-cf41e5fc9f99@intel.com \
--to=ferruh.yigit@intel.com \
--cc=chenxux.di@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).