From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Mcnamara, John" <john.mcnamara@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] [PATCH v6] doc: document NIC features
Date: Fri, 4 Aug 2017 12:40:43 +0100 [thread overview]
Message-ID: <b495372b-8523-d5b6-48c5-8937da776064@intel.com> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23ED5AA4C@IRSMSX103.ger.corp.intel.com>
On 8/4/2017 12:11 PM, Mcnamara, John wrote:
>> -----Original Message-----
>> From: Thomas Monjalon [mailto:thomas@monjalon.net]
>> Sent: Friday, August 4, 2017 10:32 AM
>> To: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; Olivier Matz
>> <olivier.matz@6wind.com>
>> Subject: Re: [dpdk-dev] [PATCH v6] doc: document NIC features
>>
>> 04/08/2017 10:56, Ferruh Yigit:
>>> On 8/3/2017 11:57 PM, Thomas Monjalon wrote:
>>>> 01/08/2017 17:23, Ferruh Yigit:
>>>>> +:orphan:
>>>>> +
>>>>> +.. _nic_overview_features:
>>>>
>>>> Why have you done an orphan page?
>>>> I think it should be in doc/guides/nics/overview.rst
>>>
>>> There is a link from nics/overview.rst to this file. But this file is
>>> not in the index and not making it orphan is causing a build warning.
>>
>> But why creating a new page?
>> It could be below the table in overview.rst.
>
> For me it makes more sense on a separate page. It isn't really overview material.
>
> However, thinking about it again I think that it should be included in the index
> instead of using the :orphan: directive. Maybe after the compilation chapter/page.
I will send a new version that has been included into index.
Thanks,
ferruh
>
> John
>
next prev parent reply other threads:[~2017-08-04 11:40 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-15 16:37 [dpdk-dev] [RFC] " Ferruh Yigit
2017-06-21 13:25 ` [dpdk-dev] [PATCH] " Ferruh Yigit
2017-06-22 19:02 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2017-07-02 20:20 ` Mcnamara, John
2017-07-05 13:20 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
2017-07-05 16:03 ` Mcnamara, John
2017-07-07 10:55 ` Andrew Rybchenko
2017-07-07 13:37 ` Ferruh Yigit
2017-07-07 13:53 ` Thomas Monjalon
2017-07-07 13:57 ` Ferruh Yigit
2017-07-07 14:02 ` Thomas Monjalon
2017-07-07 14:13 ` Ferruh Yigit
2017-07-07 14:20 ` Wiles, Keith
2017-07-07 20:37 ` Thomas Monjalon
2017-07-07 23:54 ` Wiles, Keith
2017-07-07 15:06 ` Ferruh Yigit
2017-07-07 15:38 ` Andrew Rybchenko
2017-07-07 17:21 ` [dpdk-dev] [PATCH v4] " Ferruh Yigit
2017-07-08 9:47 ` Andrew Rybchenko
2017-07-20 9:10 ` Ferruh Yigit
2017-07-20 9:23 ` [dpdk-dev] [PATCH v5] " Ferruh Yigit
2017-07-26 5:08 ` Shreyansh Jain
2017-08-01 10:15 ` Ferruh Yigit
2017-08-01 15:23 ` [dpdk-dev] [PATCH v6] " Ferruh Yigit
2017-08-03 8:56 ` Shreyansh Jain
2017-08-03 8:57 ` Shreyansh Jain
2017-08-03 10:42 ` Mcnamara, John
2017-08-03 22:57 ` Thomas Monjalon
2017-08-04 8:56 ` Ferruh Yigit
2017-08-04 9:32 ` Thomas Monjalon
2017-08-04 10:04 ` Ferruh Yigit
2017-08-04 10:10 ` Thomas Monjalon
2017-08-04 11:11 ` Mcnamara, John
2017-08-04 11:40 ` Ferruh Yigit [this message]
2017-08-04 13:06 ` [dpdk-dev] [PATCH v7] " Ferruh Yigit
2017-08-04 13:34 ` Mcnamara, John
2017-08-05 9:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b495372b-8523-d5b6-48c5-8937da776064@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=olivier.matz@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).