From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Fan Zhang <roy.fan.zhang@intel.com>, dev@dpdk.org
Cc: ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix session id printf
Date: Tue, 10 Apr 2018 11:41:36 +0200 [thread overview]
Message-ID: <b4bea11d-2589-13c4-39d6-da7ba449cfad@redhat.com> (raw)
In-Reply-To: <20180409182116.47161-1-roy.fan.zhang@intel.com>
On 04/09/2018 08:21 PM, Fan Zhang wrote:
> Fixes: 85a2d5cab96f ("vhost/crypto: add virtio-crypto user message structure")
>
> Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> ---
> lib/librte_vhost/vhost_crypto.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c
> index d84513e7f..06c0d3398 100644
> --- a/lib/librte_vhost/vhost_crypto.c
> +++ b/lib/librte_vhost/vhost_crypto.c
> @@ -381,8 +381,8 @@ vhost_crypto_create_sess(struct vhost_crypto *vcrypto,
> return;
> }
>
> - VC_LOG_DBG("Session (key %lu, session %p) created.",
> - vcrypto->last_session_id, session);
> + VC_LOG_INFO("Session %"PRIu64" created for vdev %i.",
> + vcrypto->last_session_id, vcrypto->dev->vid);
>
> sess_param->session_id = vcrypto->last_session_id;
> vcrypto->last_session_id++;
> @@ -399,17 +399,17 @@ vhost_crypto_close_sess(struct vhost_crypto *vcrypto, uint64_t session_id)
> (void **)&session);
>
> if (unlikely(ret < 0)) {
> - VC_LOG_ERR("Failed to delete session (key %lu).", session_id);
> + VC_LOG_ERR("Failed to delete session %"PRIu64".", session_id);
> return -VIRTIO_CRYPTO_INVSESS;
> }
>
> if (rte_cryptodev_sym_session_clear(vcrypto->cid, session) < 0) {
> - VC_LOG_DBG("Failed to delete session");
> + VC_LOG_DBG("Failed to clear session");
> return -VIRTIO_CRYPTO_ERR;
> }
>
> if (rte_cryptodev_sym_session_free(session) < 0) {
> - VC_LOG_DBG("Failed to delete session");
> + VC_LOG_DBG("Failed to free session");
> return -VIRTIO_CRYPTO_ERR;
> }
>
> @@ -418,8 +418,8 @@ vhost_crypto_close_sess(struct vhost_crypto *vcrypto, uint64_t session_id)
> return -VIRTIO_CRYPTO_ERR;
> }
>
> - VC_LOG_DBG("Session (key %lu, session %p) deleted.", sess_id,
> - session);
> + VC_LOG_INFO("Session %"PRIu64" deleted for vdev %i.", sess_id,
> + vcrypto->dev->vid);
>
> return 0;
> }
>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
I'll squash it with faulty commit if not yet merged by Ferruh.
Thanks,
Maxime
next prev parent reply other threads:[~2018-04-10 9:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-09 15:34 [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs Fan Zhang
2018-04-09 15:34 ` [dpdk-dev] [PATCH] lib/librte_vhost: remove packet dump Fan Zhang
2018-04-11 8:47 ` Maxime Coquelin
2018-04-11 8:59 ` Maxime Coquelin
2018-04-11 14:36 ` Maxime Coquelin
2018-04-09 15:45 ` [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs Maxime Coquelin
2018-04-09 15:53 ` Maxime Coquelin
2018-04-09 16:38 ` [dpdk-dev] [PATCH v2] vhost/crypto: " Fan Zhang
2018-04-09 17:57 ` [dpdk-dev] [PATCH] examples/vhost_crypto: fix parsing Fan Zhang
2018-04-10 9:40 ` Maxime Coquelin
2018-04-09 18:01 ` [dpdk-dev] [PATCH] vhost/crypto: fix makefile Fan Zhang
2018-04-10 9:41 ` Maxime Coquelin
2018-04-09 18:21 ` [dpdk-dev] [PATCH] vhost/crypto: fix session id printf Fan Zhang
2018-04-10 9:41 ` Maxime Coquelin [this message]
2018-04-11 9:22 ` [dpdk-dev] [PATCH] vhost/crypto: fix incorrect formatting Fan Zhang
2018-04-11 9:56 ` Maxime Coquelin
2018-04-10 7:32 ` [dpdk-dev] [PATCH] lib/librte_vhost: fix bugs Wodkowski, PawelX
2018-04-10 7:43 ` Maxime Coquelin
2018-04-10 7:47 ` Wodkowski, PawelX
2018-04-10 7:55 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b4bea11d-2589-13c4-39d6-da7ba449cfad@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).