From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, dev@dpdk.org
Cc: Yuanhan Liu <yliu@fridaylinux.org>, Tetsuya Mukawa <mtetsuyah@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/2] vhost: introduce rte_vhost_vring_call()
Date: Tue, 2 Jan 2018 11:27:02 +0100 [thread overview]
Message-ID: <b5459c8d-daa0-e9a2-0479-5cdd9a73de89@redhat.com> (raw)
In-Reply-To: <20180102093136.28690-1-stefanha@redhat.com>
Hi Stefan,
On 01/02/2018 10:31 AM, Stefan Hajnoczi wrote:
> v2:
> * Add internal vhost_vring_call() helper function [Maxime]
>
> These patches eliminate code duplication for vhost_virtqueue->callfd users by
> introducing rte_vhost_vring_call() (public API) and vhost_vring_call()
> (librte_vhost-internal API).
>
> Stefan Hajnoczi (2):
> vhost: add vhost_vring_call() helper
> vhost: introduce rte_vhost_vring_call()
>
> lib/librte_vhost/rte_vhost.h | 15 +++++++++++++++
> lib/librte_vhost/vhost.h | 12 ++++++++++++
> examples/vhost/virtio_net.c | 11 ++---------
> examples/vhost_scsi/vhost_scsi.c | 6 +++---
> lib/librte_vhost/vhost.c | 21 +++++++++++++++++++++
> lib/librte_vhost/virtio_net.c | 23 +++--------------------
> lib/librte_vhost/rte_vhost_version.map | 7 +++++++
> 7 files changed, 63 insertions(+), 32 deletions(-)
>
I just wonder whether tagging the new API as experimental is needed,
but apart from that it looks good to me:
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks!
Maxime
next prev parent reply other threads:[~2018-01-02 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-02 9:31 Stefan Hajnoczi
2018-01-02 9:31 ` [dpdk-dev] [PATCH v2 1/2] vhost: add vhost_vring_call() helper Stefan Hajnoczi
2018-01-02 9:31 ` [dpdk-dev] [PATCH v2 2/2] vhost: introduce rte_vhost_vring_call() Stefan Hajnoczi
2018-01-02 10:27 ` Maxime Coquelin [this message]
[not found] ` <20180102181141.GC22252@stefanha-x1.localdomain>
2018-01-03 8:17 ` [dpdk-dev] [PATCH v2 0/2] " Maxime Coquelin
2018-01-08 13:46 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5459c8d-daa0-e9a2-0479-5cdd9a73de89@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=mtetsuyah@gmail.com \
--cc=stefanha@redhat.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).