From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: dev@dpdk.org, tiwei.bie@intel.com, yliu@fridaylinux.org,
jfreimann@redhat.com, jianfeng.tan@intel.com
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2 2/2] vhost: remove pending IOTLB entry if IOTLB MISS request sending failed
Date: Mon, 29 Jan 2018 17:31:53 +0100 [thread overview]
Message-ID: <b5dd2ca2-4e3a-dc4c-6bd3-512c2d6e57ac@redhat.com> (raw)
In-Reply-To: <20180129151347.23640-3-maxime.coquelin@redhat.com>
On 01/29/2018 04:13 PM, Maxime Coquelin wrote:
> @@ -52,8 +54,13 @@ __vhost_iova_to_vva(struct virtio_net *dev, struct vhost_virtqueue *vq,
> */
> vhost_user_iotlb_rd_unlock(vq);
>
> - vhost_user_iotlb_pending_insert(vq, iova + tmp_size, perm);
> - vhost_user_iotlb_miss(dev, iova + tmp_size, perm);
> + vhost_user_iotlb_pending_insert(vq, iova, perm);
> + if (vhost_user_iotlb_miss(dev, iova, perm)) {
> + RTE_LOG(ERR, VHOST_CONFIG,
> + "Failed to send IOTLB miss request for IOVA %lx\n",
> + iova + tmp_size);
Oops, the correct value is "iova", not "iova + tmp_size"
I just posted v3 fixing it.
Maxime
prev parent reply other threads:[~2018-01-29 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 15:13 [dpdk-stable] [PATCH v2 0/2] vhost: IOTLB fixes Maxime Coquelin
2018-01-29 15:13 ` [dpdk-stable] [PATCH v2 1/2] vhost: fix iotlb pool out-of-memory handling Maxime Coquelin
2018-01-29 15:13 ` [dpdk-stable] [PATCH v2 2/2] vhost: remove pending IOTLB entry if IOTLB MISS request sending failed Maxime Coquelin
2018-01-29 16:31 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5dd2ca2-4e3a-dc4c-6bd3-512c2d6e57ac@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=jfreimann@redhat.com \
--cc=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).