From: Chas Williams <3chas3@gmail.com>
To: Liang Zhang <zhangliang@bigo.sg>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] bonding: fix lacp negotiation failed
Date: Wed, 13 Mar 2019 14:02:47 -0400 [thread overview]
Message-ID: <b5f940be-1db3-fb86-b102-a24877e22d7c@gmail.com> (raw)
In-Reply-To: <1552483439-11083-1-git-send-email-zhangliang@bigo.sg>
At a minimum you need to address the long lines in your patch. See
http://mails.dpdk.org/archives/test-report/2019-March/076663.html
otherwise this looks fine to me.
On 3/13/19 9:23 AM, Liang Zhang wrote:
> When monitor(port-mirroring) traffic from other lacp port-channel,
> rx_machine_update may recieving other lacp negotiation packets.
> Thus bond mode 4 will negotiation failed.
>
> Signed-off-by: Liang Zhang <zhangliang@bigo.sg>
> ---
> drivers/net/bonding/rte_eth_bond_8023ad.c | 9 +++++++--
> drivers/net/bonding/rte_eth_bond_8023ad_private.h | 1 +
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad.c b/drivers/net/bonding/rte_eth_bond_8023ad.c
> index dd847c6..e518956 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad.c
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad.c
> @@ -784,13 +784,17 @@ static void
> rx_machine_update(struct bond_dev_private *internals, uint8_t slave_id,
> struct rte_mbuf *lacp_pkt) {
> struct lacpdu_header *lacp;
> + struct lacpdu_actor_partner_params *partner;
>
> if (lacp_pkt != NULL) {
> lacp = rte_pktmbuf_mtod(lacp_pkt, struct lacpdu_header *);
> RTE_ASSERT(lacp->lacpdu.subtype == SLOW_SUBTYPE_LACP);
>
> - /* This is LACP frame so pass it to rx_machine */
> - rx_machine(internals, slave_id, &lacp->lacpdu);
> + partner = &lacp->lacpdu.partner;
> + if (is_same_ether_addr(&partner->port_params.system, &internals->mode4.mac_addr)) {
> + /* This is LACP frame to the bonding port so pass it to rx_machine */
> + rx_machine(internals, slave_id, &lacp->lacpdu);
> + }
> rte_pktmbuf_free(lacp_pkt);
> } else
> rx_machine(internals, slave_id, NULL);
> @@ -1140,6 +1144,7 @@ bond_mode_8023ad_setup(struct rte_eth_dev *dev,
> bond_mode_8023ad_conf_assign(mode4, conf);
> mode4->slowrx_cb = conf->slowrx_cb;
> mode4->agg_selection = AGG_STABLE;
> + rte_eth_macaddr_get(internals->port_id, &mode4->mac_addr);
>
> if (dev->data->dev_started)
> bond_mode_8023ad_start(dev);
> diff --git a/drivers/net/bonding/rte_eth_bond_8023ad_private.h b/drivers/net/bonding/rte_eth_bond_8023ad_private.h
> index c51426b..f91902e 100644
> --- a/drivers/net/bonding/rte_eth_bond_8023ad_private.h
> +++ b/drivers/net/bonding/rte_eth_bond_8023ad_private.h
> @@ -150,6 +150,7 @@ struct mode8023ad_private {
> uint64_t update_timeout_us;
> rte_eth_bond_8023ad_ext_slowrx_fn slowrx_cb;
> uint8_t external_sm;
> + struct ether_addr mac_addr;
>
> struct rte_eth_link slave_link;
> /***< slave link properties */
>
next prev parent reply other threads:[~2019-03-13 18:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 13:23 Liang Zhang
2019-03-13 18:02 ` Chas Williams [this message]
2019-03-14 12:27 ` [dpdk-dev] [PATCH v2] bonding: change mac_addr filled position Liang Zhang
2019-03-14 12:27 ` Liang Zhang
2019-03-15 8:53 ` [dpdk-dev] [PATCH v3 1/2] bonding: fix lacp negotiation failed Liang Zhang
2019-03-15 8:53 ` Liang Zhang
2019-03-15 8:53 ` [dpdk-dev] [PATCH v3 2/2] bonding: change mac_addr filled position Liang Zhang
2019-03-15 8:53 ` Liang Zhang
2019-03-14 12:09 ` [dpdk-dev] [PATCH v2] " Liang Zhang
2019-03-14 12:09 ` Liang Zhang
2019-03-15 9:06 [dpdk-dev] [PATCH] bonding: fix lacp negotiation failed Liang Zhang
2019-03-15 9:06 ` Liang Zhang
2019-03-18 13:45 ` Chas Williams
2019-03-18 13:45 ` Chas Williams
2019-03-19 16:03 ` Kevin Traynor
2019-03-19 16:03 ` Kevin Traynor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5f940be-1db3-fb86-b102-a24877e22d7c@gmail.com \
--to=3chas3@gmail.com \
--cc=dev@dpdk.org \
--cc=zhangliang@bigo.sg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).