From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
Kevin Traynor <ktraynor@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yan, Zhirun" <zhirun.yan@intel.com>
Subject: Re: [dpdk-dev] [RFC 2/2] net/i40e: update requested queue pair num check for rounding
Date: Mon, 11 Mar 2019 12:35:48 +0000 [thread overview]
Message-ID: <b68bf6f0-d73f-a644-3408-6f466805170a@intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E706115334A38D@SHSMSX103.ccr.corp.intel.com>
On 3/11/2019 2:18 AM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Kevin Traynor [mailto:ktraynor@redhat.com]
>> Sent: Wednesday, March 6, 2019 12:31 AM
>> To: Zhang, Qi Z <qi.z.zhang@intel.com>
>> Cc: dev@dpdk.org; Kevin Traynor <ktraynor@redhat.com>; Yan, Zhirun
>> <zhirun.yan@intel.com>
>> Subject: [RFC 2/2] net/i40e: update requested queue pair num check for
>> rounding
>>
>> Since rounding up the requested queue pairs to allow the vf to request a
>> non-aligned number was added, it may happen that the requested number is
>> less than the available num of queues but the rounded up number is greater. In
>> this case, it is not caught with the usual checks but later when there is a reset and
>> failed setup.
>>
>> By rounding earlier the checks can be done before a failed reset occurs, and a
>> rounded max amount of available queues can be returned to the vf.
>>
>> Cc: zhirun.yan@intel.com
>> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
>
These were checkpatch warnings because of whitespace (spaces before tabs), fixed
while merging to next-net.
next prev parent reply other threads:[~2019-03-11 12:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-05 16:30 [dpdk-dev] [PATCH 1/2] net/i40e: fix negative check on unsigned queue pairs Kevin Traynor
2019-03-05 16:30 ` [dpdk-dev] [RFC 2/2] net/i40e: update requested queue pair num check for rounding Kevin Traynor
2019-03-11 2:18 ` Zhang, Qi Z
2019-03-11 12:35 ` Ferruh Yigit [this message]
2019-03-11 18:38 ` Kevin Traynor
2019-03-07 13:42 ` [dpdk-dev] [PATCH 1/2] net/i40e: fix negative check on unsigned queue pairs Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b68bf6f0-d73f-a644-3408-6f466805170a@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=qi.z.zhang@intel.com \
--cc=zhirun.yan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).