From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Luca Boccassi <bluca@debian.org>,
xiangxia.m.yue@gmail.com, jianfeng.tan@intel.com,
yliu@fridaylinux.org
Cc: stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset
Date: Mon, 30 Apr 2018 15:46:18 +0200 [thread overview]
Message-ID: <b6a20295-d381-75e4-19e9-2d12a6907ccc@redhat.com> (raw)
In-Reply-To: <1525095883.23337.21.camel@debian.org>
On 04/30/2018 03:44 PM, Luca Boccassi wrote:
> On Fri, 2018-04-27 at 07:48 -0700, xiangxia.m.yue@gmail.com wrote:
>> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>>
>> When qemu close the unix socket fd of the vhostuser as a
>> server, and then immediately delete the vhostuser port on
>> openvswitch. There will be a deadlock.
>>
>> A thread (fdset event thread): B thread:
>> 1. fdset_event_dispatch rte_vhost_driver_unregister
>> 2. set the fd busy to 1. lock vsocket->conn_mutex
>> 3. vhost_user_read_cb fdset_del waits busy changed to
>> 0.
>> 4. vhost peer closed, remove the
>> conn from vsocket->conn_list:
>> lock vsocket->conn_mutex
>>
>> 5. set the fd busy to 0
>>
>> Fixes: 65388b43 ("vhost: fix fd leaks for vhost-user server mode")
>> Cc: stable@dpdk.org
>> Cc: Yuanhan Liu <yliu@fridaylinux.org>
>> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> Hi, has a version of this series been merged into mainline?
>
No, not yet.
In my plans for -rc2.
Cheers,
Maxime
next prev parent reply other threads:[~2018-04-30 13:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 14:48 xiangxia.m.yue
2018-04-27 14:48 ` [dpdk-stable] [PATCH 2/3] vhost: fix crash and fd leak due to vhostuser destroyed xiangxia.m.yue
2018-04-30 13:44 ` [dpdk-stable] [PATCH 1/3] vhost: fix deadlock due to vhostuser socket and fdset Luca Boccassi
2018-04-30 13:46 ` Maxime Coquelin [this message]
2018-04-27 15:19 xiangxia.m.yue
2018-05-04 13:00 ` Maxime Coquelin
2018-05-04 15:11 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6a20295-d381-75e4-19e9-2d12a6907ccc@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=bluca@debian.org \
--cc=jianfeng.tan@intel.com \
--cc=stable@dpdk.org \
--cc=xiangxia.m.yue@gmail.com \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).