From: "Hunt, David" <david.hunt@intel.com>
Cc: dev@dpdk.org, Marcin Hajkowski <marcinx.hajkowski@intel.com>,
"Daly, Lee" <lee.daly@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 4/4] power: add cmd to query CPU freq
Date: Fri, 27 Sep 2019 13:38:09 +0100 [thread overview]
Message-ID: <b6bb59c2-9c4c-1303-c326-4f717fbce5d6@intel.com> (raw)
In-Reply-To: <20190927121601.23661-5-david.hunt@intel.com>
On 27/09/2019 13:16, David Hunt wrote:
> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
>
> Add command and related logic to query CPU frequencies
> either for specified CPU or all cores.
>
> Signed-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> Tested-by: David Hunt <david.hunt@intel.com>
> Acked-by: Lee Daly <lee.daly@intel.com>
> ---
> .../guest_cli/vm_power_cli_guest.c | 150 ++++++++++++++++--
> 1 file changed, 138 insertions(+), 12 deletions(-)
>
This patch set looks functionally good.
Some of the test steps I ran through are as follows:
Initialy attempt to query frequency from guest, it failed because
queries were disabled.
vmpower> set_query ubuntu3 disable
vmpower(guest)> query_cpu_freq all
GUEST_CLI: Error receiving message.
Error during frequency list reception
Then I enabled queries for the VM:
vmpower> set_query ubuntu3 enable
I was then able to query the freq list for all the cores in the VM:
vmpower(guest)> query_cpu_freq all
Frequency of [0] vcore is 2300000.
*Frequency of [1] vcore is 2300000.*
Frequency of [2] vcore is 2300000.
Frequency of [3] vcore is 2300000.
Frequency of [4] vcore is 2300000.
Frequency of [5] vcore is 2300000.
Frequency of [6] vcore is 2300000.
Frequency of [7] vcore is 2300000.
When a freq was changed in a core:
vmpower(guest)> set_cpu_freq 1 down
ACK received for message sent to host.
The frequency of core 1 had changed in the query, as expected:
vmpower(guest)> query_cpu_freq all
Frequency of [0] vcore is 2300000.
*Frequency of [1] vcore is 2200000.*
Frequency of [2] vcore is 2300000.
Frequency of [3] vcore is 2300000.
Frequency of [4] vcore is 2300000.
Frequency of [5] vcore is 2300000.
Frequency of [6] vcore is 2300000.
Frequency of [7] vcore is 2300000.
I've added a Tested-by tag to the v2 patchset.
Rgds,
Dave.
next prev parent reply other threads:[~2019-09-27 12:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 17:15 [dpdk-dev] [PATCH 0/4] Frequency list query Hajkowski
2019-04-03 17:15 ` Hajkowski
2019-04-03 17:15 ` [dpdk-dev] [PATCH 1/4] power: extend guest channel for query freq Hajkowski
2019-04-03 17:15 ` Hajkowski
2019-09-27 12:15 ` [dpdk-dev] [PATCH v2 0/4] frequency list query from guest David Hunt
2019-09-27 12:15 ` [dpdk-dev] [PATCH v2 1/4] power: extend guest channel for query freq David Hunt
2019-09-30 9:54 ` Hunt, David
2019-09-27 12:15 ` [dpdk-dev] [PATCH v2 2/4] power: process cpu freq query David Hunt
2019-09-27 12:16 ` [dpdk-dev] [PATCH v2 3/4] power: add mechanism to disable queries David Hunt
2019-09-27 12:16 ` [dpdk-dev] [PATCH v2 4/4] power: add cmd to query CPU freq David Hunt
2019-09-27 12:38 ` Hunt, David [this message]
2019-10-27 19:59 ` [dpdk-dev] [PATCH v2 0/4] frequency list query from guest Thomas Monjalon
2019-04-03 17:15 ` [dpdk-dev] [PATCH 2/4] power: process cpu freq. query Hajkowski
2019-04-03 17:15 ` Hajkowski
2019-04-03 17:15 ` [dpdk-dev] [PATCH 3/4] power: add mechanism to disable queries Hajkowski
2019-04-03 17:15 ` Hajkowski
2019-04-03 17:16 ` [dpdk-dev] [PATCH 4/4] power: add cmd to query CPU freq Hajkowski
2019-04-03 17:16 ` Hajkowski
2019-09-27 9:52 ` Daly, Lee
2019-09-27 10:19 ` Ferruh Yigit
2019-09-27 10:40 ` Hunt, David
2019-07-04 19:57 ` [dpdk-dev] [PATCH 0/4] Frequency list query Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6bb59c2-9c4c-1303-c326-4f717fbce5d6@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=lee.daly@intel.com \
--cc=marcinx.hajkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).