From: Tetsuya Mukawa <mukawa@igel.co.jp>
To: David Marchand <david.marchand@6wind.com>
Cc: Thomas Monjalon <thomas.monjalon@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Mcnamara, John" <john.mcnamara@intel.com>,
michalx.k.jastrzebski@intel.com
Subject: Re: [dpdk-dev] [PATCH v2] eal: Fix resource leak while secondary process maps pci devices
Date: Mon, 20 Jun 2016 11:19:57 +0900 [thread overview]
Message-ID: <b6e77a7d-fb9b-1c81-2cb3-da692d3ba3b6@igel.co.jp> (raw)
In-Reply-To: <CALwxeUt9oTkr5wQQfRcHQeJvXhCb5Z4cwt9Q-ubEBpKP+gpFow@mail.gmail.com>
On 2016/06/17 21:28, David Marchand wrote:
> On Thu, Jun 16, 2016 at 4:33 AM, Tetsuya Mukawa <mukawa@igel.co.jp> wrote:
>> This patch fixes resource leak of pci_uio_map_secondary().
>> If pci_map_resource() succeeds but mapped address is different from an
>> address primary process mapped, this should be error.
>> Then the addresses secondary process mapped should be freed.
>>
>> Signed-off-by: Tetsuya Mukawa <mukawa@igel.co.jp>
>
> scripts/check-git-log.sh is not happy :
>
> Wrong headline uppercase:
> eal: Fix resource leak while secondary process maps pci devices
> Wrong headline lowercase:
> eal: Fix resource leak while secondary process maps pci devices
> Headline too long:
> eal: Fix resource leak while secondary process maps pci devices
> Missing 'Fixes' tag:
> eal: Fix resource leak while secondary process maps pci devices
>
>
> checkpatch is not happy, but I think we can ignore it.
>
> WARNING:LONG_LINE: line over 80 characters
> #48: FILE: lib/librte_eal/common/eal_common_pci_uio.c:93:
> + (size_t)uio_res->maps[j].size);
>
>
> Anyways, looks good to me, Thomas, can you fix the commit logs of
> those last 3 patches on eal ?
> Thanks.
>
Hi David,
I appreciate your checking.
Next time I will check check-git-log.sh before submitting.
Hi Thomas,
Could you please let me know if you need the fixed patches.
Best,
Tetsuya
next prev parent reply other threads:[~2016-06-20 2:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 3:26 [dpdk-dev] [PATCH] eal: Fix wrong error checking of rte_eal_parse_devargs_str() Tetsuya Mukawa
2016-06-15 14:48 ` David Marchand
2016-06-16 2:03 ` Tetsuya Mukawa
2016-06-16 2:33 ` [dpdk-dev] [PATCH v2] eal: Fix wrong error checking while parsing device arguments Tetsuya Mukawa
2016-06-15 3:26 ` [dpdk-dev] [PATCH] eal: Fix resource leak of pci_uio_map_secondary() Tetsuya Mukawa
2016-06-15 14:45 ` David Marchand
2016-06-16 2:03 ` Tetsuya Mukawa
2016-06-16 2:33 ` [dpdk-dev] [PATCH v2] eal: Fix resource leak while secondary process maps pci devices Tetsuya Mukawa
2016-06-17 12:28 ` David Marchand
2016-06-20 2:19 ` Tetsuya Mukawa [this message]
2016-06-20 8:50 ` Thomas Monjalon
2016-06-15 3:27 ` [dpdk-dev] [PATCH] eal: Fix wrong resource release of pci_uio_unmap() Tetsuya Mukawa
2016-06-15 15:01 ` David Marchand
2016-06-16 2:33 ` [dpdk-dev] [PATCH v2] eal: Fix wrong resource release while unmapping pci devices Tetsuya Mukawa
2016-06-17 12:12 ` David Marchand
2016-06-20 8:50 ` Thomas Monjalon
2016-06-17 12:10 ` [dpdk-dev] [PATCH v2] eal: Fix wrong error checking while parsing device arguments David Marchand
2016-06-20 8:49 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6e77a7d-fb9b-1c81-2cb3-da692d3ba3b6@igel.co.jp \
--to=mukawa@igel.co.jp \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).