From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Cc: Olivier MATZ <olivier.matz@6wind.com>,
Igor Ryzhov <iryzhov@nfware.com>,
Laurent Hardy <laurent.hardy@6wind.com>,
Ivan Malov <ivan.malov@oktetlabs.ru>,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] net/sfc: fix main MAC address handling
Date: Thu, 21 Dec 2017 11:30:38 -0800 [thread overview]
Message-ID: <b7690929-cd52-36d0-c612-869cb1c382a1@intel.com> (raw)
In-Reply-To: <1513763534-32279-1-git-send-email-arybchenko@solarflare.com>
On 12/20/2017 1:52 AM, Andrew Rybchenko wrote:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
>
> There is a school of thought that rte_eth_dev_default_mac_addr_set()
> must call the PMD callback first and then save the new MAC address
> in dev->data->mac_addrs[0].
:)
> If this concept gets approved, it will
> break the current approach used in sfc driver as the latter relies
> on the assumption that the new MAC address is already contained in
> dev->data->mac_addrs[0], and, if adapter restart is needed to make
> the HW apply the new address, the outdated value will be retrieved
> from dev->data. In order to preclude any possible bugs, this patch
> adds device private storage for the up-to-date copy of the address.
Thank you for taking care of this.
>
> Fixes: c100fd464bb7 ("net/sfc: support main MAC address change")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2017-12-21 19:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-20 9:52 Andrew Rybchenko
2017-12-21 19:30 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7690929-cd52-36d0-c612-869cb1c382a1@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=iryzhov@nfware.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=laurent.hardy@6wind.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).