From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: switch to the new offload API
Date: Fri, 30 Mar 2018 11:38:41 +0100 [thread overview]
Message-ID: <b7830d88-2b20-5994-1a95-b3b630a8f52d@intel.com> (raw)
In-Reply-To: <20180326224753.25304-1-ajit.khaparde@broadcom.com>
On 3/26/2018 11:47 PM, Ajit Khaparde wrote:
> Update bnxt PMD to new ethdev offloads API.
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
> v1->v2: return an error if requested offload flags do not
> match supported offload capabilities.
<...>
> +
> + dev_info->rx_queue_offload_capa = BNXT_DEV_RX_OFFLOAD_SUPPORT;
Hi Ajit,
Is bnxt supports queue level offloads? If not PMD should return 0 as
rx_queue_offload_capa and tx_queue_offload_capa.
<...>
> .rx_free_thresh = 32,
> - .rx_drop_en = 0,
> + /* If no descriptors available, pkts are dropped by default */
> + .rx_drop_en = 1,
This is not related to the offload API but changing default config, does it make
sense a separate patch for this?
next prev parent reply other threads:[~2018-03-30 10:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 19:40 [dpdk-dev] [PATCH] " Ajit Khaparde
2018-03-21 19:08 ` Ferruh Yigit
2018-03-21 19:27 ` Ajit Khaparde
2018-03-22 6:22 ` Shahaf Shuler
2018-03-26 22:47 ` [dpdk-dev] [PATCH v2] " Ajit Khaparde
2018-03-30 10:38 ` Ferruh Yigit [this message]
2018-04-02 22:25 ` [dpdk-dev] [PATCH v3 1/2] " Ajit Khaparde
2018-04-02 22:25 ` [dpdk-dev] [PATCH v3 2/2] net/bnxt: fix rx_drop_en setting Ajit Khaparde
2018-04-05 14:36 ` [dpdk-dev] [PATCH v3 1/2] net/bnxt: switch to the new offload API Ferruh Yigit
2018-04-06 0:22 ` [dpdk-dev] [PATCH v4 1/2] net/bnxt: fix rx_drop_en setting Ajit Khaparde
2018-04-06 0:22 ` [dpdk-dev] [PATCH v4 2/2] net/bnxt: switch to the new offload API Ajit Khaparde
2018-04-06 15:11 ` Ferruh Yigit
2018-04-07 17:40 ` [dpdk-dev] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting Ajit Khaparde
2018-04-07 17:40 ` [dpdk-dev] [PATCH v5 2/2] net/bnxt: switch to the new offload API Ajit Khaparde
2018-04-09 16:53 ` [dpdk-dev] [dpdk-stable] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7830d88-2b20-5994-1a95-b3b630a8f52d@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).