From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Seth Howell <seth.howell@intel.com>
Cc: dev@dpdk.org, Darek Stojaczyk <dariusz.stojaczyk@intel.com>
Subject: Re: [dpdk-dev] [PATCH] malloc: notify primary process about hotplug in secondary
Date: Wed, 5 Dec 2018 10:36:37 +0000 [thread overview]
Message-ID: <b78d3cc4-e66d-ec59-755d-f54c1986ee88@intel.com> (raw)
In-Reply-To: <20181204170610.250124-1-seth.howell@intel.com>
On 04-Dec-18 5:06 PM, Seth Howell wrote:
> When secondary process hotplugs memory, it sends a request
> to primary, which then performs the real mmap() and sends
> sync requests to all secondary processes. Upon receiving
> such sync request, each secondary process will notify the
> upper layers of hotplugged memory (and will call all
> locally registered event callbacks).
>
> In the end we'll end up with memory event callbacks fired
> in all the processes except the primary, which is a bug.
>
> This gets critical if memory is hotplugged while a VFIO
> device is attached, as the VFIO memory registration -
> which is done from a memory event callback present in the
> primary process only - is never called.
>
> After this patch, a primary process fires memory event
> callbacks before secondary processes start their
> synchronizations - both for hotplug and hotremove.
>
> Change-Id: I60de33913f58bc2454069c3844826c92cb043fff
This is internal tag, please don't include it in the patch. Also, misses
Fixes: tag, and Cc: stable@dpdk.org (since this bug goes back to 18.05).
> Signed-off-by: Seth Howell <seth.howell@intel.com>
> Signed-off-by: Darek Stojaczyk <dariusz.stojaczyk@intel.com>
> ---
Otherwise,
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2018-12-05 10:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 17:06 Seth Howell
2018-12-05 10:36 ` Burakov, Anatoly [this message]
2018-12-07 20:06 ` Seth Howell
2018-12-07 20:10 ` [dpdk-dev] [PATCH v2] " Seth Howell
2018-12-10 10:49 ` Burakov, Anatoly
2018-12-20 14:26 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b78d3cc4-e66d-ec59-755d-f54c1986ee88@intel.com \
--to=anatoly.burakov@intel.com \
--cc=dariusz.stojaczyk@intel.com \
--cc=dev@dpdk.org \
--cc=seth.howell@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).