DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Matej Vido <vido@cesnet.cz>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/5] net/szedata2: refactor ibuf and obuf names
Date: Mon, 29 May 2017 13:40:57 +0100	[thread overview]
Message-ID: <b89a6f4e-29e4-8594-fa99-ba53f7cc7531@intel.com> (raw)
In-Reply-To: <1495821956-5050-1-git-send-email-vido@cesnet.cz>

On 5/26/2017 7:05 PM, Matej Vido wrote:
> Signed-off-by: Matej Vido <vido@cesnet.cz>

Hi Matej,

Overall patchset looks good to me, but can you please provide a little
more information in commit logs, please check comments on patches.

For this patch, it seems refactor naming is removing "cgmii", what is
the reason of this, is cgmii no more true or adding different interface?

Thanks,
ferruh

> ---
>  drivers/net/szedata2/rte_eth_szedata2.c |   80 +++++++++++++++---------------
>  drivers/net/szedata2/rte_eth_szedata2.h |   48 +++++++++---------
>  2 files changed, 64 insertions(+), 64 deletions(-)

<...>

  parent reply	other threads:[~2017-05-29 12:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-26 18:05 Matej Vido
2017-05-26 18:05 ` [dpdk-dev] [PATCH 2/5] net/szedata2: refactor ibuf and obuf read and write Matej Vido
2017-05-26 18:05 ` [dpdk-dev] [PATCH 3/5] net/szedata2: refactor ibuf and obuf address definition Matej Vido
2017-05-29 12:41   ` Ferruh Yigit
2017-05-31  8:33     ` Matej Vido
2017-05-31  9:12       ` Ferruh Yigit
2017-05-26 18:05 ` [dpdk-dev] [PATCH 4/5] net/szedata2: move ibuf and obuf to specific header Matej Vido
2017-05-26 18:05 ` [dpdk-dev] [PATCH 5/5] net/szedata2: add more supported firmwares Matej Vido
2017-05-29 12:42   ` Ferruh Yigit
2017-05-31  8:34     ` Matej Vido
2017-05-31  9:11       ` Ferruh Yigit
2017-05-29 12:40 ` Ferruh Yigit [this message]
2017-05-31  8:32   ` [dpdk-dev] [PATCH 1/5] net/szedata2: refactor ibuf and obuf names Matej Vido
2017-06-12 12:03 ` [dpdk-dev] [PATCH v2 " Matej Vido
2017-06-12 12:03   ` [dpdk-dev] [PATCH v2 2/5] net/szedata2: refactor ibuf and obuf read and write Matej Vido
2017-06-12 12:03   ` [dpdk-dev] [PATCH v2 3/5] net/szedata2: refactor ibuf and obuf address definition Matej Vido
2017-06-12 12:03   ` [dpdk-dev] [PATCH v2 4/5] net/szedata2: move ibuf and obuf to specific header Matej Vido
2017-06-12 12:03   ` [dpdk-dev] [PATCH v2 5/5] net/szedata2: add more supported firmwares Matej Vido
2017-06-12 14:35   ` [dpdk-dev] [PATCH v2 1/5] net/szedata2: refactor ibuf and obuf names Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b89a6f4e-29e4-8594-fa99-ba53f7cc7531@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=vido@cesnet.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).