From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ilya Matveychikov <matvejchikov@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] mbuf: remove redundant line in rte_pktmbuf_attach
Date: Fri, 20 Jan 2017 12:08:45 +0000 [thread overview]
Message-ID: <b8f694f5-ac20-7ac1-5bdf-809ccf3aef9f@intel.com> (raw)
In-Reply-To: <7181C1FE-0FB9-4FB8-9A12-08AB4506880E@gmail.com>
On 1/20/2017 12:19 AM, Ilya Matveychikov wrote:
> mi->next will be assigned to NULL few lines later, trivial patch
>
> Signed-off-by: Ilya V. Matveychikov <matvejchikov@gmail.com>
> ---
> lib/librte_mbuf/rte_mbuf.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h
> index ead7c6e..5589d54 100644
> --- a/lib/librte_mbuf/rte_mbuf.h
> +++ b/lib/librte_mbuf/rte_mbuf.h
> @@ -1139,7 +1139,6 @@ static inline void rte_pktmbuf_attach(struct rte_mbuf *mi, struct rte_mbuf *m)
> mi->buf_addr = m->buf_addr;
> mi->buf_len = m->buf_len;
>
> - mi->next = m->next;
Do you know why attaching mbuf is not supporting multi-segment?
Perhaps this can be documented in function comment, as one of the "not
supported" items.
Also, should we check mi->next before overwriting, in case it is not NULL?
> mi->data_off = m->data_off;
> mi->data_len = m->data_len;
> mi->port = m->port;
>
next prev parent reply other threads:[~2017-01-20 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 0:19 Ilya Matveychikov
2017-01-20 12:08 ` Ferruh Yigit [this message]
2017-01-21 15:08 ` Ilya Matveychikov
2017-01-21 16:28 ` Ananyev, Konstantin
2017-01-24 12:56 ` Olivier MATZ
2017-01-24 15:57 ` Ilya Matveychikov
2017-01-24 16:19 ` Olivier MATZ
2017-01-30 8:57 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8f694f5-ac20-7ac1-5bdf-809ccf3aef9f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=matvejchikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).