From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Alan Elder <alan.elder@microsoft.com>,
Long Li <longli@microsoft.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: "dev@dpdk.org" <dev@dpdk.org>, stephen <stephen@networkplumber.org>
Subject: Re: [PATCH v5] net/netvsc: fix parsing of VLAN metadata
Date: Fri, 16 Feb 2024 11:33:37 +0000 [thread overview]
Message-ID: <b9339090-f5e8-4783-a9ce-a30e9296dac6@amd.com> (raw)
In-Reply-To: <PA4PR83MB0526A094C53E5613C0A669A3974D2@PA4PR83MB0526.EURPRD83.prod.outlook.com>
On 2/15/2024 6:12 PM, Alan Elder wrote:
> The previous code incorrectly parsed the VLAN ID and priority.
> If the 16-bits of VLAN ID and priority/CFI on the wire was
> 0123456789ABCDEF the code parsed it as 456789ABCDEF3012. There
> were macros defined to handle this conversion but they were not
> used.
>
> Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device")
> Cc: sthemmin@microsoft.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Alan Elder <alan.elder@microsoft.com>
>
Thanks Alan, overall looks good to me.
Can you please make separate the lib/net patch?
As first patch lib/net updates, second updates the net/vetvsc.
> ---
> v5:
> * Move the VLAN parsing macros to rte_ether.h
>
> v4:
> * Make consistent with FreeBSD code
>
> ---
> .mailmap | 1 +
> drivers/net/netvsc/hn_rxtx.c | 8 ++++++--
> lib/net/rte_ether.h | 16 ++++++++++++++++
> 3 files changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/.mailmap b/.mailmap
> index a0756974e2..eca02318d6 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -33,6 +33,7 @@ Alain Leon <xerebz@gmail.com>
> Alan Brady <alan.brady@intel.com>
> Alan Carew <alan.carew@intel.com>
> Alan Dewar <alan.dewar@att.com> <adewar@brocade.com>
> +Alan Elder <alan.elder@microsoft.com>
> Alan Liu <zaoxingliu@gmail.com>
> Alan Winkowski <walan@marvell.com>
> Alejandro Lucero <alejandro.lucero@netronome.com>
> diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c
> index e4f5015aa3..9bf1ec5509 100644
> --- a/drivers/net/netvsc/hn_rxtx.c
> +++ b/drivers/net/netvsc/hn_rxtx.c
> @@ -612,7 +612,9 @@ static void hn_rxpkt(struct hn_rx_queue *rxq, struct hn_rx_bufinfo *rxb,
> RTE_PTYPE_L4_MASK);
>
> if (info->vlan_info != HN_NDIS_VLAN_INFO_INVALID) {
> - m->vlan_tci = info->vlan_info;
> + m->vlan_tci = RTE_VLAN_TCI_MAKE(NDIS_VLAN_INFO_ID(info->vlan_info),
> + NDIS_VLAN_INFO_PRI(info->vlan_info),
> + NDIS_VLAN_INFO_CFI(info->vlan_info));
>
Is there a good reason why format is not same as spec format?
prev parent reply other threads:[~2024-02-16 11:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-08 15:09 [PATCH v3] " Alan Elder
2024-02-09 1:18 ` Long Li
2024-02-09 15:50 ` [PATCH v4] " Alan Elder
2024-02-14 22:17 ` Long Li
2024-02-15 11:46 ` Ferruh Yigit
2024-02-15 18:12 ` [PATCH v5] " Alan Elder
2024-02-15 18:25 ` Stephen Hemminger
2024-02-16 9:43 ` [PATCH v6] " Alan Elder
2024-02-16 11:39 ` Ferruh Yigit
2024-02-19 9:31 ` [PATCH v7 0/2] " Alan Elder
2024-02-19 9:31 ` [PATCH v7 1/2] lib/net: " Alan Elder
2024-02-19 11:12 ` Ferruh Yigit
2024-02-19 11:14 ` Ferruh Yigit
2024-02-19 9:31 ` [PATCH v7 2/2] net/netvsc: " Alan Elder
2024-02-19 11:12 ` Ferruh Yigit
2024-02-19 9:34 ` [EXTERNAL] Re: [PATCH v6] " Alan Elder
2024-02-16 11:33 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9339090-f5e8-4783-a9ce-a30e9296dac6@amd.com \
--to=ferruh.yigit@amd.com \
--cc=alan.elder@microsoft.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).