From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Ori Kam <orika@nvidia.com>,
Alexander Kozyrev <akozyrev@nvidia.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>
Subject: Re: [PATCH v3] ethdev: add flow rule actions update API
Date: Tue, 23 May 2023 11:34:15 +0100 [thread overview]
Message-ID: <ba0f7bae-4d46-acc2-0618-1ebf68a630be@amd.com> (raw)
In-Reply-To: <MW2PR12MB466610269E675E1CF0F2B0E0D6409@MW2PR12MB4666.namprd12.prod.outlook.com>
On 5/23/2023 7:59 AM, Ori Kam wrote:
> Hi
>
>> -----Original Message-----
>> From: Ferruh Yigit <ferruh.yigit@amd.com>
>> Sent: Monday, May 22, 2023 1:28 PM
>>
>> On 5/18/2023 10:48 PM, Alexander Kozyrev wrote:
>>> Introduce the new rte_flow_update() API allowing users
>>> to update the action list in the already existing rule.
>>
>> If the API is only to update actions, does make sense to rename it to
>> explicitly state this, like:
>> `rte_flow_action_update()`
>>
>> Same for async version of the API.
>>
>
> I'm O.K with the suggested name.
> Maybe just change action to actions?
>
Both OK for me, existing APIs have mixed usage of 'action' vs 'actions',
is there a clear distinction when to use one or other?
> Best,
> Ori
>
>>> Flow rules can be updated now without the need to destroy
>>> the rule first and create a new one instead.
>>> A single API call ensures that no packets are lost by
>>> guaranteeing atomicity and flow state correctness.
>>> The rte_flow_async_update() is added as well.
>>> The matcher is not updated, only the action list is.
>>>
>>> Signed-off-by: Alexander Kozyrev <akozyrev@nvidia.com>
>>
>> <...>
next prev parent reply other threads:[~2023-05-23 10:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 19:58 [PATCH] " Alexander Kozyrev
2023-05-18 15:37 ` Ori Kam
2023-05-18 19:54 ` Alexander Kozyrev
2023-05-18 19:49 ` [PATCH v2] " Alexander Kozyrev
2023-05-18 21:48 ` [PATCH v3] " Alexander Kozyrev
2023-05-21 19:07 ` Ori Kam
2023-05-22 10:28 ` Ferruh Yigit
2023-05-23 6:59 ` Ori Kam
2023-05-23 10:34 ` Ferruh Yigit [this message]
2023-05-23 11:20 ` Ori Kam
2023-05-23 18:39 ` [PATCH v4] " Alexander Kozyrev
2023-05-24 11:00 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba0f7bae-4d46-acc2-0618-1ebf68a630be@amd.com \
--to=ferruh.yigit@amd.com \
--cc=akozyrev@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).