From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Hyong Youb Kim <hyonkim@cisco.com>
Cc: dev@dpdk.org, John Daley <johndale@cisco.com>
Subject: Re: [dpdk-dev] [PATCH v2 13/13] net/enic: fix several issues with inner packet matching
Date: Mon, 4 Mar 2019 16:58:28 +0000 [thread overview]
Message-ID: <bac17e86-943a-3520-b8f4-8ec1dc005c7c@intel.com> (raw)
In-Reply-To: <20190302104251.32565-14-hyonkim@cisco.com>
On 3/2/2019 10:42 AM, Hyong Youb Kim wrote:
> Inner packet matching is currently buggy in many cases.
>
> 1. Mishandling null spec ("match any").
> The copy_item functions do nothing if spec is null. This is incorrect,
> as all patterns should be appended to the L5 pattern buffer even for
> null spec (treated as all zeros).
>
> 2. Accessing null spec causing segfault.
>
> 3. Not setting protocol fields.
> The NIC filter API currently has no flags for "match inner IPv4, IPv6,
> UDP, TCP, and so on". So, the driver needs to explicitly set EtherType
> and IP protocol fields in the L5 pattern buffer to avoid false
> positives (e.g. reporting IPv6 as IPv4).
>
> Instead of keep adding "if inner, do something differently" cases to
> the existing copy_item functions, introduce separate functions for
> inner packet patterns and address the above issues in those
> functions. The changes to the previous outer-packet copy_item
> functions are mechanical, due to reduced indentation.
>
> Fixes: 6ced137607d0 ("net/enic: flow API for NICs with advanced filters enabled")
>
> Signed-off-by: Hyong Youb Kim <hyonkim@cisco.com>
<...>
I have added "Cc: stable@dpdk.org" tag while merging. If the tag explicitly left
out to prevent backport please let me know to remove the tag back.
next prev parent reply other threads:[~2019-03-04 16:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-02 10:42 [dpdk-dev] [PATCH v2 00/13] net/enic: 19.05 updates Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 01/13] net/enic: remove unused code Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 02/13] net/enic: fix flow director SCTP matching Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 03/13] net/enic: fix SCTP match for flow API Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 04/13] net/enic: allow flow mark ID 0 Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 05/13] net/enic: check for unsupported flow item types Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 06/13] net/enic: enable limited RSS flow action Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 07/13] net/enic: enable limited PASSTHRU " Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 08/13] net/enic: move arguments into struct Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 09/13] net/enic: enable limited support for RAW flow item Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 10/13] net/enic: reset VXLAN port regardless of overlay offload Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 11/13] net/enic: fix a couple issues with VXLAN match Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 12/13] net/enic: fix an endian bug in VLAN match Hyong Youb Kim
2019-03-02 10:42 ` [dpdk-dev] [PATCH v2 13/13] net/enic: fix several issues with inner packet matching Hyong Youb Kim
2019-03-04 16:58 ` Ferruh Yigit [this message]
2019-04-10 17:06 ` Kevin Traynor
2019-04-10 17:06 ` Kevin Traynor
2019-03-04 16:56 ` [dpdk-dev] [PATCH v2 00/13] net/enic: 19.05 updates Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bac17e86-943a-3520-b8f4-8ec1dc005c7c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=hyonkim@cisco.com \
--cc=johndale@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).