From: Kevin Traynor <ktraynor@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com
Cc: stable@dpdk.org
Subject: Re: [PATCH] vhost: decrease log level for unimplemented request
Date: Thu, 8 Dec 2022 11:10:36 +0000 [thread overview]
Message-ID: <bb824b0c-0c2a-f70f-3ff9-9c50f9768c60@redhat.com> (raw)
In-Reply-To: <20221206150257.70926-1-maxime.coquelin@redhat.com>
On 06/12/2022 15:02, Maxime Coquelin wrote:
> This patch changes VHOST_USER_SET_VRING_ERR "not
> implemented" log level from INFO to DEBUG.
>
> Indeed, it is not required to support this message type,
> and since version 7.1, QEMU sends this message for every
> queue. It could confuse the end-user, thinking there is an
> issue where there are not.
>
> Implementing it could be an option, but it does nothing
> special on QEMU side but displaying an error message.
>
> Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
> lib/vhost/vhost_user.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 9902ae9944..371d6304d6 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -1809,7 +1809,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev,
>
> if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK))
> close(ctx->fds[0]);
> - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n");
> + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n");
>
> return RTE_VHOST_MSG_RESULT_OK;
> }
Debug level seem fine for this and this is what is done in QEMU. Not an
issue atm from what I see, but should we do the same for
VHOST_USER_SET_LOG_FD ?
next prev parent reply other threads:[~2022-12-08 11:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 15:02 Maxime Coquelin
2022-12-08 11:10 ` Kevin Traynor [this message]
2023-01-27 11:37 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb824b0c-0c2a-f70f-3ff9-9c50f9768c60@redhat.com \
--to=ktraynor@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).