From: Declan Doherty <declan.doherty@intel.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>, thomas@monjalon.net
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/4] cryptodev: remove socket id check
Date: Thu, 22 Jun 2017 12:27:39 +0100 [thread overview]
Message-ID: <bce1e09b-eb70-94fb-7363-0d3cbdac8456@intel.com> (raw)
In-Reply-To: <20170621050733.88850-2-pablo.de.lara.guarch@intel.com>
On 21/06/2017 6:07 AM, Pablo de Lara wrote:
> Socket id parsed from the user was checked
> if it was in the range of available sockets.
> This check is unnecessary, as the socket specified
> might not have memory anyway, so it will fail
> at memory allocation.
>
> Therefore, the best solution is to remove this check.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> lib/librte_cryptodev/rte_cryptodev.c | 22 ----------------------
...
>
Acked-by: Declan Doherty <declan.doherty@intel.com>
next prev parent reply other threads:[~2017-06-22 11:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-20 23:25 [dpdk-dev] [PATCH 0/5] eal: check socket memory Pablo de Lara
2017-06-20 23:25 ` [dpdk-dev] [PATCH 1/5] eal: check if socket has memory reserved Pablo de Lara
2017-06-20 23:25 ` [dpdk-dev] [PATCH 2/5] cryptodev: check if socket id has memory Pablo de Lara
2017-06-20 23:25 ` [dpdk-dev] [PATCH 3/5] crypto/scheduler: " Pablo de Lara
2017-06-20 23:25 ` [dpdk-dev] [PATCH 4/5] net/bonding: " Pablo de Lara
2017-06-20 23:25 ` [dpdk-dev] [PATCH 5/5] test/bonding: " Pablo de Lara
2017-06-21 5:07 ` [dpdk-dev] [PATCH v2 0/4] Socket ID check removal Pablo de Lara
2017-06-21 5:07 ` [dpdk-dev] [PATCH v2 1/4] cryptodev: remove socket id check Pablo de Lara
2017-06-22 11:27 ` Declan Doherty [this message]
2017-06-21 5:07 ` [dpdk-dev] [PATCH v2 2/4] crypto/scheduler: " Pablo de Lara
2017-06-22 11:38 ` Declan Doherty
2017-06-21 5:07 ` [dpdk-dev] [PATCH v2 3/4] net/bonding: " Pablo de Lara
2017-06-22 11:47 ` Declan Doherty
2017-06-21 5:07 ` [dpdk-dev] [PATCH v2 4/4] test/bonding: " Pablo de Lara
2017-06-22 11:48 ` Declan Doherty
2017-06-22 15:47 ` [dpdk-dev] [PATCH v2 0/4] Socket ID check removal Thomas Monjalon
2017-06-21 11:33 ` [dpdk-dev] [PATCH 0/5] eal: check socket memory De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bce1e09b-eb70-94fb-7363-0d3cbdac8456@intel.com \
--to=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).