From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Fady Bader <fady@mellanox.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <tbashar@mellanox.com>,
<talshn@mellanox.com>, <yohadt@mellanox.com>,
<dmitry.kozliuk@gmail.com>, <olivier.matz@6wind.com>,
<mdr@ashroe.eu>, <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows
Date: Sun, 31 May 2020 16:02:21 +0300 [thread overview]
Message-ID: <bd42a5b0-4b32-3fc1-fc5c-62d70a292ea1@solarflare.com> (raw)
In-Reply-To: <20200531124151.16848-2-fady@mellanox.com>
On 5/31/20 3:41 PM, Fady Bader wrote:
> Tracing is not supported for Windows.
> Disabled all trace calls in for Windows.
>
> Signed-off-by: Fady Bader <fady@mellanox.com>
> ---
> lib/librte_mempool/mempool_trace_points.c | 4 ++++
> lib/librte_mempool/rte_mempool.c | 20 ++++++++++++++++++++
> lib/librte_mempool/rte_mempool.h | 22 ++++++++++++++++++++++
> lib/librte_mempool/rte_mempool_ops.c | 8 ++++++++
> lib/librte_mempool/rte_mempool_trace_fp.h | 3 +++
> 5 files changed, 57 insertions(+)
>
> diff --git a/lib/librte_mempool/mempool_trace_points.c b/lib/librte_mempool/mempool_trace_points.c
> index df4368b17..51f0d1705 100644
> --- a/lib/librte_mempool/mempool_trace_points.c
> +++ b/lib/librte_mempool/mempool_trace_points.c
> @@ -2,7 +2,9 @@
> * Copyright(C) 2020 Marvell International Ltd.
> */
>
> +#ifndef RTE_EXEC_ENV_WINDOWS
> #include <rte_trace_point_register.h>
> +#endif
I really dislike the approach. It adds too many conditional
compilation statements which make code harder to read.
You can have dummy implementation of these functions on
Windows to avoid the conditional compilation.
...
next prev parent reply other threads:[~2020-05-31 13:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-31 12:41 [dpdk-dev] [PATCH 0/5] build mempool on Windows Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 1/5] mempool: disable tracing for Windows Fady Bader
2020-05-31 13:02 ` Andrew Rybchenko [this message]
2020-06-01 1:54 ` Dmitry Kozlyuk
2020-05-31 13:49 ` Jerin Jacob
2020-05-31 12:41 ` [dpdk-dev] [PATCH 2/5] eal: disable function versioning on Windows Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 3/5] mempool: use generic memory management Fady Bader
2020-05-31 13:06 ` Andrew Rybchenko
2020-05-31 12:41 ` [dpdk-dev] [PATCH 4/5] eal: export needed functions for mempool Fady Bader
2020-05-31 12:41 ` [dpdk-dev] [PATCH 5/5] mempool: mempool build on Windows Fady Bader
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd42a5b0-4b32-3fc1-fc5c-62d70a292ea1@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=olivier.matz@6wind.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=thomas@monjalon.net \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).