From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Rushil Gupta <rushilg@google.com>,
"Guo, Junfeng" <junfeng.guo@intel.com>
Cc: "Richardson, Bruce" <bruce.richardson@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"techboard@dpdk.org" <techboard@dpdk.org>
Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
Date: Wed, 12 Apr 2023 17:02:54 +0100 [thread overview]
Message-ID: <bd480d32-2f30-f999-e8b4-de86f58e09d3@amd.com> (raw)
In-Reply-To: <CANzqiF44C3HX1TMk5430EpDLL+GSifPTfZZdJd918m++zCrBUg@mail.gmail.com>
On 4/12/2023 4:42 PM, Rushil Gupta wrote:
>
>
> On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng <junfeng.guo@intel.com
> <mailto:junfeng.guo@intel.com>> wrote:
>
>
>
> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@amd.com
> <mailto:ferruh.yigit@amd.com>>
> > Sent: Wednesday, April 12, 2023 17:35
> > To: Guo, Junfeng <junfeng.guo@intel.com
> <mailto:junfeng.guo@intel.com>>; Richardson, Bruce
> > <bruce.richardson@intel.com <mailto:bruce.richardson@intel.com>>
> > Cc: dev@dpdk.org <mailto:dev@dpdk.org>; Zhang, Qi Z
> <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>; Rushil Gupta
> > <rushilg@google.com <mailto:rushilg@google.com>>
> > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
> >
> > On 4/12/2023 10:09 AM, Guo, Junfeng wrote:
> > >
> > >
> > >> -----Original Message-----
> > >> From: Ferruh Yigit <ferruh.yigit@amd.com
> <mailto:ferruh.yigit@amd.com>>
> > >> Sent: Wednesday, April 12, 2023 16:50
> > >> To: Guo, Junfeng <junfeng.guo@intel.com
> <mailto:junfeng.guo@intel.com>>; Richardson, Bruce
> > >> <bruce.richardson@intel.com <mailto:bruce.richardson@intel.com>>
> > >> Cc: dev@dpdk.org <mailto:dev@dpdk.org>; Zhang, Qi Z
> <qi.z.zhang@intel.com <mailto:qi.z.zhang@intel.com>>; Rushil Gupta
> > >> <rushilg@google.com <mailto:rushilg@google.com>>
> > >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQO
> > >>
> > >> On 4/11/2023 7:51 AM, Guo, Junfeng wrote:
> > >>
> > >> Hi Junfeng, message moved down.
> > >>
> > >>>
> > >>>> -----Original Message-----
> > >>>> From: Rushil Gupta <rushilg@google.com
> <mailto:rushilg@google.com>>
> > >>>> Sent: Tuesday, April 11, 2023 12:59
> > >>>> To: Zhang, Qi Z <qi.z.zhang@intel.com
> <mailto:qi.z.zhang@intel.com>>; ferruh.yigit@amd.com
> <mailto:ferruh.yigit@amd.com>
> > >>>> Cc: Richardson, Bruce <bruce.richardson@intel.com
> <mailto:bruce.richardson@intel.com>>;
> > dev@dpdk.org <mailto:dev@dpdk.org>;
> > >>>> Rushil Gupta <rushilg@google.com
> <mailto:rushilg@google.com>>; Guo, Junfeng
> > >>>> <junfeng.guo@intel.com <mailto:junfeng.guo@intel.com>>
> > >>>> Subject: [PATCH 1/1] net/gve: update base code for DQO
> > >>>>
> > >>>> Update gve base code to support DQO.
> > >>>>
> > >>>> This patch is based on this:
> > >>>>
> > https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*
> <https://patchwork.dpdk.org/project/dpdk/list/?series=27647&state=*>
> > >>>>
> > >>>> Signed-off-by: Rushil Gupta <rushilg@google.com
> <mailto:rushilg@google.com>>
> > >>>> Signed-off-by: Junfeng Guo <junfeng.guo@intel.com
> <mailto:junfeng.guo@intel.com>>
> > >>> Hi Ferruh & Bruce,
> > >>>
> > >>> This patch contains few lines change for the MIT licensed gve base
> > code.
> > >>> Note that there is no new files added, just some minor code
> update.
> > >>>
> > >>> Do we need to ask for special approval from the Tech Board for
> this?
> > >>> Please help give some advice and also help review this patch.
> Thanks!
> > >>>
> > >>
> > >> Once the MIT license exception is in place, as far as I know no
> more
> > >> approval is required per change.
> > >
> > > Got it, thanks the comment!
> > >
> > > Then we may also need your help to review, as well as the coming
> patch
> > > set for GVE PMD enhancement for DPDK 23.07. Thanks in advance!
> > >
> > >>
> > >>> BTW, Google will also help replace all the base code under MIT
> > license
> > >>> with the ones under BSD-3 license soon, which would make things
> > more
> > >>> easier.
> > >>>
> > >>
> > >> Is this different from base code under DPDK is changing license
> [1] ?
> > >>
> > >>
> > >> [1]
> > >>
> >
> https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar <https://patches.dpdk.org/project/dpdk/list/?series=27570&state=%2A&ar>
> > >> chive=both
> > >>
> > >
> > > The patch set of the above link only contains the processing of
> replace
> > the
> > > MIT licensed base code with the BSD-3 licensed base code. After some
> > > discussion, we think Google is in the right place to do that
> work. And
> > they
> > > are working on that now.
> > >
> >
> > Is the Google GVE driver [2] in the process of changing license
> from MIT
> > to BSD-3?
> >
> >
> > [2]
> > https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-
> <https://github.com/GoogleCloudPlatform/compute-virtual-ethernet->
> > linux/tree/v1.3.0/google/gve
> >
>
> I'm not sure, I don't know much about Google's plans.
> Maybe they could provide some info here. Thanks!
>
> @Rushil Gupta
>
> >
> >
> > > This patch is mainly for the feature upstreaming of DPDK 23.07. It
> > contains
> > > only the code part, following previous license statements,
> without any
> > > license change.
> > >
> > > This patch is separated and sent by Google, to ensure there is
> no license
> > > violation.
> > >
> > > BTW, about the feature of GVE PMD enhancement, the rest code are all
> > > about BSD-3 licensed files, and that patch set will be sent out
> soon.
> > >
> > > Thanks!
>
> I have got the green light internally to switch to BSD-3 license for
> code under base directory. If it is ok with the tech board, I can send a
> patch right away with all of the base files changed to BSD-3 which can
> be merged after this patch. Please let me know what you think.
> We are also about to upstream driver
> code: https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd <https://github.com/GoogleCloudPlatform/compute-virtual-ethernet-freebsd> to FreeBSD as well so you will see similar code under BSD license soon in freebsd repo.
+techboard
There is already a patch [1] to change dpdk gve driver license from MIT
to BSD-3, what will be different in the patch you are planning to send?
Or overall I am trying to understand what is this new development on top
of existing patch.
next prev parent reply other threads:[~2023-04-12 16:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 4:59 [PATCH 0/1] *** Update drivers/net/gve/base code for DQO *** Rushil Gupta
2023-04-11 4:59 ` [PATCH 1/1] net/gve: update base code for DQO Rushil Gupta
2023-04-11 6:51 ` Guo, Junfeng
2023-04-12 8:50 ` Ferruh Yigit
2023-04-12 9:09 ` Guo, Junfeng
2023-04-12 9:34 ` Ferruh Yigit
2023-04-12 9:41 ` Guo, Junfeng
2023-04-12 15:42 ` Rushil Gupta
2023-04-12 16:02 ` Ferruh Yigit [this message]
2023-04-12 18:04 ` Rushil Gupta
2023-04-14 5:17 ` Rushil Gupta
2023-04-14 11:00 ` Ferruh Yigit
2023-05-04 8:30 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bd480d32-2f30-f999-e8b4-de86f58e09d3@amd.com \
--to=ferruh.yigit@amd.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=junfeng.guo@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rushilg@google.com \
--cc=techboard@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).