From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
jianfeng.tan@intel.com, tiwei.bie@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] Revert "vhost: avoid concurrency when logging dirty pages"
Date: Fri, 27 Apr 2018 15:34:03 +0100 [thread overview]
Message-ID: <bde83fce-62a6-6873-bbac-852f8740ce17@intel.com> (raw)
In-Reply-To: <20180420083921.28025-1-maxime.coquelin@redhat.com>
On 4/20/2018 9:39 AM, Maxime Coquelin wrote:
> This reverts commit 394313fff39d0f994325c47f7eab39daf5dc9e11.
>
> While the patch did solve concurrency issue, it induces more
> pages copies as some clean pages are marked as dirty for
> performance reasons. Moreover, as there is no more contention
> doing the logging, the rate of packets than can be processed is
> higher, leading to even more pages to be dirtied.
>
> It has been reported that with more than one queue pair, and
> with a relatively low packet rate (1Mpps), the live migration
> never converges until the flow is stopped.
>
> While a better solution is found, it is better to reset to the
> old behaviour, i.e. using atomic operation for dirty pages
> logging.
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2018-04-27 14:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 8:39 Maxime Coquelin
2018-04-27 14:34 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bde83fce-62a6-6873-bbac-852f8740ce17@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=maxime.coquelin@redhat.com \
--cc=tiwei.bie@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).