From: "John Daley (johndale)" <johndale@cisco.com>
To: Aaron Conole <aconole@redhat.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC 4/4] enic: remove anscillary assignment
Date: Tue, 10 Oct 2017 17:32:06 +0000 [thread overview]
Message-ID: <be159937fe9f4055b3783d4e992f8e02@XCH-RCD-007.cisco.com> (raw)
In-Reply-To: <20170926185329.2776-5-aconole@redhat.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Aaron Conole
> Sent: Tuesday, September 26, 2017 11:53 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [RFC 4/4] enic: remove anscillary assignment
>
> The assignment at initialization is overwritten immediately. Drop the
> assignment.
>
> Signed-off-by: Aaron Conole <aconole@redhat.com>
> ---
> drivers/net/enic/base/vnic_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/enic/base/vnic_dev.c
> b/drivers/net/enic/base/vnic_dev.c
> index a4b7f4b..932667f 100644
> --- a/drivers/net/enic/base/vnic_dev.c
> +++ b/drivers/net/enic/base/vnic_dev.c
> @@ -272,7 +272,7 @@ int vnic_dev_alloc_desc_ring(struct vnic_dev *vdev,
> __attribute__((unused)) unsigned int socket_id,
> char *z_name)
> {
> - void *alloc_addr = NULL;
> + void *alloc_addr;
> dma_addr_t alloc_pa = 0;
>
> vnic_dev_desc_ring_size(ring, desc_count, desc_size);
> --
> 2.9.5
Reviewed-by: John Daley <johndale@cisco.com>
Thanks,
Johnd
next prev parent reply other threads:[~2017-10-10 17:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 18:53 [dpdk-dev] [RFC 0/4] misc enic fixes Aaron Conole
2017-09-26 18:53 ` [dpdk-dev] [RFC 1/4] enic: update format string to match arg types Aaron Conole
2017-10-10 17:30 ` John Daley (johndale)
2017-09-26 18:53 ` [dpdk-dev] [RFC 2/4] enic: fix assignment Aaron Conole
2017-10-10 17:31 ` John Daley (johndale)
2017-09-26 18:53 ` [dpdk-dev] [RFC 3/4] enic: remove unused code Aaron Conole
2017-10-10 17:31 ` John Daley (johndale)
2017-09-26 18:53 ` [dpdk-dev] [RFC 4/4] enic: remove anscillary assignment Aaron Conole
2017-10-10 17:32 ` John Daley (johndale) [this message]
2017-10-03 16:16 ` [dpdk-dev] [RFC 0/4] misc enic fixes Ferruh Yigit
2017-10-09 14:00 ` Aaron Conole
2017-10-10 23:06 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be159937fe9f4055b3783d4e992f8e02@XCH-RCD-007.cisco.com \
--to=johndale@cisco.com \
--cc=aconole@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).