From: "Hunt, David" <david.hunt@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix default PFC setting
Date: Tue, 11 Apr 2017 11:11:54 +0100 [thread overview]
Message-ID: <be3680f5-78c9-1f9b-8218-5f3d9f3465d5@intel.com> (raw)
In-Reply-To: <1491896149-29328-1-git-send-email-jingjing.wu@intel.com>
On 11/4/2017 8:35 AM, Jingjing Wu wrote:
> To keep consistent with previous release, PFC need to be disabled
> by default. This patch fixes it.
>
> Fixes: 6f0a707e5b55 ("net/i40e: enable DCB on SRIOV VFs")
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 6927fde..3e640b3 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -10266,8 +10266,6 @@ i40e_dcb_init_configure(struct rte_eth_dev *dev, bool sw_dcb)
> hw->local_dcbx_config.pfc.willing = 0;
> hw->local_dcbx_config.pfc.pfccap =
> I40E_MAX_TRAFFIC_CLASS;
> - hw->local_dcbx_config.pfc.pfcenable =
> - I40E_DEFAULT_TCMAP;
> /* FW needs one App to configure HW */
> hw->local_dcbx_config.numapps = 1;
> hw->local_dcbx_config.app[0].selector =
This also fixes an issue I was having occasionally where traffic was not
forwarded by testpmd on my platform. In those cases I was seeing ~4770
pps on one of the ports rather than the full rate (>20mpps).
A git bisect confirmed that this commit (6f0a707e5b55) was the source of
the issue.
Tested-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2017-04-11 10:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-11 7:35 Jingjing Wu
2017-04-11 10:11 ` Hunt, David [this message]
2017-04-11 11:24 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be3680f5-78c9-1f9b-8218-5f3d9f3465d5@intel.com \
--to=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).