DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Chaoyong He <chaoyong.he@corigine.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: oss-drivers <oss-drivers@corigine.com>,
	Niklas Soderlund <niklas.soderlund@corigine.com>
Subject: Re: [PATCH v7 01/12] net/nfp: move app specific attributes to own struct
Date: Tue, 6 Sep 2022 10:35:08 +0100	[thread overview]
Message-ID: <be92eab9-d7ec-944a-2aae-c85ea49e10f4@xilinx.com> (raw)
In-Reply-To: <SJ0PR13MB5545770C042E0AF0DB6911709E7E9@SJ0PR13MB5545.namprd13.prod.outlook.com>

On 9/6/2022 10:20 AM, Chaoyong He wrote:
> 
>> From: Ferruh Yigit <ferruh.yigit@xilinx.com>
>> Sent: Monday, September 5, 2022 11:38 PM
>> To: Chaoyong He <chaoyong.he@corigine.com>; dev@dpdk.org
>> Cc: oss-drivers <oss-drivers@corigine.com>; Niklas Soderlund
>> <niklas.soderlund@corigine.com>; Heinrich Kuhn
>> <heinrich.kuhn@corigine.com>
>> Subject: Re: [PATCH v7 01/12] net/nfp: move app specific attributes to own
>> struct
>>
>> On 8/12/2022 11:22 AM, Chaoyong He wrote:
>>> The NFP Card can load different firmware applications. Currently only
>>> the CoreNIC application is supported. This commit makes needed
>>> infrastructure changes in order to support other firmware applications
>>> too.
>>>
>>
>> App (or firmware application) is a little confusing, why not just call it FW?
>>
>> Same for code variable/struct names, and other patches.
> 
> We decided to not just use "FW", as this is an overloaded term for the NFP.
> There is also the lower-level management FW, which is flashed to the card and
>   is mostly separate to the application firmware, although they do interact with
>   each other.
> The application firmware is the software (application) that runs on the card's flow
>   processors, is loaded during run time, and determines the behavior of the card.
> To avoid confusion with the different types of firmware we decided to call this
> the app_firmware - this is also similar to what is happening in the nfp kernel driver.
> 
> To avoid further confuse, we will change the places where just use "app" to be "app_fw" instead.
> 

OK to 'app_fw'

>>> Clearer separation is made between the PF device and any application
>>> specific concepts. The PF struct is now generic regardless of the
>>> application loaded. A new struct is also made for the CoreNIC
>>> application. Future additions to support other applications should
>>> also add an applications specific struct.
>>>
>>> Signed-off-by: Chaoyong He<chaoyong.he@corigine.com>
>>> Signed-off-by: Heinrich Kuhn<heinrich.kuhn@corigine.com>
>>> Reviewed-by: Niklas Söderlund<niklas.soderlund@corigine.com>
> 


  reply	other threads:[~2022-09-06  9:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-12 10:22 [PATCH v7 00/12] preparation for the rte_flow offload of nfp PMD Chaoyong He
2022-08-12 10:22 ` [PATCH v7 01/12] net/nfp: move app specific attributes to own struct Chaoyong He
2022-09-05 15:38   ` Ferruh Yigit
2022-09-06  9:20     ` Chaoyong He
2022-09-06  9:35       ` Ferruh Yigit [this message]
2022-08-12 10:22 ` [PATCH v7 02/12] net/nfp: simplify initialization and remove dead code Chaoyong He
2022-08-12 10:22 ` [PATCH v7 03/12] net/nfp: move app specific init logic to own function Chaoyong He
2022-09-05 15:38   ` Ferruh Yigit
2022-09-06  8:29     ` Chaoyong He
2022-09-06  9:47       ` Ferruh Yigit
2022-08-12 10:22 ` [PATCH v7 04/12] net/nfp: add initial flower firmware support Chaoyong He
2022-09-05 15:39   ` Ferruh Yigit
2022-09-07  8:22     ` Chaoyong He
2022-09-07 13:24       ` Ferruh Yigit
2022-08-12 10:22 ` [PATCH v7 05/12] net/nfp: add flower PF setup and mempool init logic Chaoyong He
2022-09-05 15:42   ` Ferruh Yigit
2022-09-06  8:45     ` Chaoyong He
2022-09-06 10:18       ` Ferruh Yigit
2022-08-12 10:22 ` [PATCH v7 06/12] net/nfp: add flower PF related routines Chaoyong He
2022-08-12 10:22 ` [PATCH v7 07/12] net/nfp: add flower ctrl VNIC related logics Chaoyong He
2022-08-12 10:22 ` [PATCH v7 08/12] net/nfp: move common rxtx function for flower use Chaoyong He
2022-08-12 10:22 ` [PATCH v7 09/12] net/nfp: add flower ctrl VNIC rxtx logic Chaoyong He
2022-09-05 15:42   ` Ferruh Yigit
2022-08-12 10:22 ` [PATCH v7 10/12] net/nfp: add flower representor framework Chaoyong He
2022-08-12 10:22 ` [PATCH v7 11/12] net/nfp: move rxtx function to header file Chaoyong He
2022-08-12 10:22 ` [PATCH v7 12/12] net/nfp: add flower PF rxtx logic Chaoyong He
2022-09-01 22:10 ` [PATCH v7 00/12] preparation for the rte_flow offload of nfp PMD Niklas Söderlund
2022-09-05 15:40 ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be92eab9-d7ec-944a-2aae-c85ea49e10f4@xilinx.com \
    --to=ferruh.yigit@xilinx.com \
    --cc=chaoyong.he@corigine.com \
    --cc=dev@dpdk.org \
    --cc=niklas.soderlund@corigine.com \
    --cc=oss-drivers@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).