From: Ferruh Yigit <ferruh.yigit@intel.com>
To: John Miller <john.miller@atomicrules.com>, <dev@dpdk.org>
Subject: Re: [PATCH 4/4] net/ark: support chunk DMA transfers
Date: Wed, 26 Jan 2022 16:52:31 +0000 [thread overview]
Message-ID: <bf28555d-5c59-afce-2b1c-919051724453@intel.com> (raw)
In-Reply-To: <20220119191255.273988-4-john.miller@atomicrules.com>
On 1/19/2022 7:12 PM, John Miller wrote:
> Add support for chunk DMA transfers.
>
> Signed-off-by: John Miller <john.miller@atomicrules.com>
> ---
> drivers/net/ark/ark_ddm.c | 1 +
> drivers/net/ark/ark_ethdev_rx.c | 16 +++++++++-------
> drivers/net/ark/ark_mpu.c | 1 +
> drivers/net/ark/ark_pktchkr.c | 2 +-
> drivers/net/ark/ark_pktgen.c | 2 +-
> drivers/net/ark/ark_udm.c | 3 +++
> 6 files changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/net/ark/ark_ddm.c b/drivers/net/ark/ark_ddm.c
> index 2321371572..b16c739d50 100644
> --- a/drivers/net/ark/ark_ddm.c
> +++ b/drivers/net/ark/ark_ddm.c
> @@ -55,6 +55,7 @@ ark_ddm_stop(struct ark_ddm_t *ddm, const int wait)
> int cnt = 0;
>
> ddm->cfg.command = 2;
> + rte_wmb();
Is the new memory barrier related to the chunk DMA transfer?
> while (wait && (ddm->cfg.stop_flushed & 0x01) == 0) {
> if (cnt++ > 1000)
> return 1;
> diff --git a/drivers/net/ark/ark_ethdev_rx.c b/drivers/net/ark/ark_ethdev_rx.c
> index 1000f50be0..49134ea08f 100644
> --- a/drivers/net/ark/ark_ethdev_rx.c
> +++ b/drivers/net/ark/ark_ethdev_rx.c
> @@ -12,6 +12,7 @@
>
> #define ARK_RX_META_SIZE 32
> #define ARK_RX_META_OFFSET (RTE_PKTMBUF_HEADROOM - ARK_RX_META_SIZE)
> +#define ARK_RX_MPU_CHUNK (64U)
>
> /* Forward declarations */
> struct ark_rx_queue;
> @@ -104,7 +105,7 @@ static inline void
> eth_ark_rx_update_cons_index(struct ark_rx_queue *queue, uint32_t cons_index)
> {
> queue->cons_index = cons_index;
> - if ((cons_index + queue->queue_size - queue->seed_index) >= 64U) {
> + if ((cons_index + queue->queue_size - queue->seed_index) >= ARK_RX_MPU_CHUNK) {
> eth_ark_rx_seed_mbufs(queue);
> ark_mpu_set_producer(queue->mpu, queue->seed_index);
> }
> @@ -179,12 +180,12 @@ eth_ark_dev_rx_queue_setup(struct rte_eth_dev *dev,
> queue->reserve_q =
> rte_zmalloc_socket("Ark_rx_queue mbuf",
> nb_desc * sizeof(struct rte_mbuf *),
> - 64,
> + 512,
> socket_id);
> queue->paddress_q =
> rte_zmalloc_socket("Ark_rx_queue paddr",
> nb_desc * sizeof(rte_iova_t),
> - 64,
> + 512,
> socket_id);
>
> if (queue->reserve_q == 0 || queue->paddress_q == 0) {
> @@ -455,7 +456,8 @@ eth_ark_rx_stop_queue(struct rte_eth_dev *dev, uint16_t queue_id)
> static inline int
> eth_ark_rx_seed_mbufs(struct ark_rx_queue *queue)
> {
> - uint32_t limit = queue->cons_index + queue->queue_size;
> + uint32_t limit = (queue->cons_index & ~(ARK_RX_MPU_CHUNK - 1)) +
> + queue->queue_size;
> uint32_t seed_index = queue->seed_index;
>
> uint32_t count = 0;
> @@ -618,14 +620,14 @@ eth_ark_udm_force_close(struct rte_eth_dev *dev)
>
> ark_mpu_start(queue->mpu);
> /* Add some buffers */
> - index = 100000 + queue->seed_index;
> + index = ARK_RX_MPU_CHUNK + queue->seed_index;
100000 is replaced by '64', the diff is huge, just double checking if this
is what intended?
> ark_mpu_set_producer(queue->mpu, index);
> }
> /* Wait to allow data to pass */
> usleep(100);
>
> - ARK_PMD_LOG(DEBUG, "UDM forced flush attempt, stopped = %d\n",
> - ark_udm_is_flushed(ark->udm.v));
> + ARK_PMD_LOG(NOTICE, "UDM forced flush attempt, stopped = %d\n",
> + ark_udm_is_flushed(ark->udm.v));
> }
> ark_udm_reset(ark->udm.v);
> }
> diff --git a/drivers/net/ark/ark_mpu.c b/drivers/net/ark/ark_mpu.c
> index 8160c1de7b..b8e94b6ed3 100644
> --- a/drivers/net/ark/ark_mpu.c
> +++ b/drivers/net/ark/ark_mpu.c
> @@ -68,6 +68,7 @@ ark_mpu_reset(struct ark_mpu_t *mpu)
> int cnt = 0;
>
> mpu->cfg.command = MPU_CMD_RESET;
> + rte_wmb();
>
> while (mpu->cfg.command != MPU_CMD_IDLE) {
> if (cnt++ > 1000)
> diff --git a/drivers/net/ark/ark_pktchkr.c b/drivers/net/ark/ark_pktchkr.c
> index 84bb567a41..12a5abb2f7 100644
> --- a/drivers/net/ark/ark_pktchkr.c
> +++ b/drivers/net/ark/ark_pktchkr.c
> @@ -113,7 +113,7 @@ ark_pktchkr_stopped(ark_pkt_chkr_t handle)
> struct ark_pkt_chkr_inst *inst = (struct ark_pkt_chkr_inst *)handle;
> uint32_t r = inst->sregs->pkt_start_stop;
>
> - return (((r >> 16) & 1) == 1);
> + return (((r >> 16) & 1) == 1) || (r == 0);
> }
>
> void
> diff --git a/drivers/net/ark/ark_pktgen.c b/drivers/net/ark/ark_pktgen.c
> index 515bfe461c..6195ef997f 100644
> --- a/drivers/net/ark/ark_pktgen.c
> +++ b/drivers/net/ark/ark_pktgen.c
> @@ -107,7 +107,7 @@ ark_pktgen_paused(ark_pkt_gen_t handle)
> struct ark_pkt_gen_inst *inst = (struct ark_pkt_gen_inst *)handle;
> uint32_t r = inst->regs->pkt_start_stop;
>
> - return (((r >> 16) & 1) == 1);
> + return (((r >> 24) & 1) == 1) || (((r >> 16) & 1) == 1) || (r == 0);
Overall I am having difficulties to match changes to the commit log,
are these related changes?
Can you please give more details in the commit log what is done,
to help the review?
> }
>
> void
> diff --git a/drivers/net/ark/ark_udm.c b/drivers/net/ark/ark_udm.c
> index 28c4500a2c..9ebed89627 100644
> --- a/drivers/net/ark/ark_udm.c
> +++ b/drivers/net/ark/ark_udm.c
> @@ -33,7 +33,9 @@ ark_udm_stop(struct ark_udm_t *udm, const int wait)
> {
> int cnt = 0;
>
> + udm->setup.r0 = 0;
ditto
> udm->cfg.command = 2;
> + rte_wmb();
>
> while (wait && (udm->cfg.stop_flushed & 0x01) == 0) {
> if (cnt++ > 1000)
> @@ -70,6 +72,7 @@ ark_udm_reset(struct ark_udm_t *udm)
> void
> ark_udm_start(struct ark_udm_t *udm)
> {
> + udm->setup.r0 = 0x100;
> udm->cfg.command = 1;
> }
>
next prev parent reply other threads:[~2022-01-26 16:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-19 19:12 [PATCH 1/4] net/ark: add device capabilities record John Miller
2022-01-19 19:12 ` [PATCH 2/4] net/ark: support arbitrary mbuf size John Miller
2022-01-26 16:46 ` Ferruh Yigit
2022-01-19 19:12 ` [PATCH 3/4] net/ark: publish include file for external access John Miller
2022-01-26 16:48 ` Ferruh Yigit
2022-01-26 16:49 ` Ferruh Yigit
2022-01-19 19:12 ` [PATCH 4/4] net/ark: support chunk DMA transfers John Miller
2022-01-26 16:52 ` Ferruh Yigit [this message]
2022-01-26 16:45 ` [PATCH 1/4] net/ark: add device capabilities record Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf28555d-5c59-afce-2b1c-919051724453@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=john.miller@atomicrules.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).