From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Dai, Wei" <wei.dai@intel.com>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Yi Zhang <zhang.yi75@zte.com.cn>
Cc: "Zhang, Helin" <helin.zhang@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf
Date: Wed, 25 Jan 2017 14:40:30 +0000 [thread overview]
Message-ID: <bf29d4c9-6e72-f1cb-91ab-b9a1e577da38@intel.com> (raw)
In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D63A355A13@PGSMSX106.gar.corp.intel.com>
On 1/25/2017 1:42 AM, Dai, Wei wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dai, Wei
>> Sent: Wednesday, January 25, 2017 9:40 AM
>> To: Yuanhan Liu <yuanhan.liu@linux.intel.com>; Yi Zhang
>> <zhang.yi75@zte.com.cn>
>> Cc: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin
>> <konstantin.ananyev@intel.com>; dev@dpdk.org; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>
>> Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in ixgbevf
>>
>> I think your patch does fix an error in ixgbevf and I can acknowledge it after I
>> have checked with 82599 and x540 and x550 datasheet.
>>
>> In 82599 datasheet, there is an annotation in the chapter 1.3 Features
>> Summary (page 29) The 82599 supports full-size 15.5 KB (15872-byte) jumbo
>> packets while in a basic mode of operation. When DCB mode is enabled, or
>> security engines enabled or virtualization is enabled, the 82599 supports 9.5 KB
>> (9728-byte) jumbo packets
>>
>> In x540 datasheet, there is also an annotation in the chapter 1.3 Features
>> Summary (page 13) The X540 and 82599 support full-size 15.5 KB jumbo
>> packets while in a basic mode of operation. When DCB mode is enabled, or
>> security engines enabled, or virtualization is enabled, or OS2BMC is enabled,
>> then the X540 supports 9.5 KB jumbo packets.
>> Packets to/from MC longer than 2KB are filtered out.
>>
>> In x550 datasheet, there is still also an annotation in the chapter 1.4 Feature
>> Summary (page 23) All the products support full-size 15.5 KB jumbo packets
>> while in a basic mode of operation. When DCB mode is enabled, or security
>> engines enabled, or virtualization is enabled, or OS2BMC is enabled, then only
>> 9.5 KB jumbo packets are supported. Packets to/ from the MC longer than 2 KB
>> are filtered out.
>>
>>
>>> -----Original Message-----
>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yuanhan Liu
>>> Sent: Wednesday, December 14, 2016 3:06 PM
>>> To: Yi Zhang <zhang.yi75@zte.com.cn>
>>> Cc: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin
>>> <konstantin.ananyev@intel.com>; dev@dpdk.org
>>> Subject: Re: [dpdk-dev] [PATCH v3] net/ixgbe:fix max packet length in
>>> ixgbevf
>>>
>>> On Thu, Dec 15, 2016 at 02:50:19AM +0800, Yi Zhang wrote:
>>>> Current ixgbevf driver get max_rx_pktlen = 15872, but in fact PF
>>>> supports 15872-byte jumbo frame and VF only supports 9728-byte jumbo
>>>> frame. If VF is running DPDK driver and set frame_size > 9728 ,PF
>>>> running kernel ixgbe driver will report an error and set VF failed.
>>>> This patch fixs DPDK ixgbevf driver to get correct jumbo frame size
>>>> of VF.
>>>>
Fixes: 2144f6630fca ("ixgbe: add redirection table size in device info")
Cc: stable@dpdk.org
>>>> Signed-off-by: Yi Zhang <zhang.yi75@zte.com.cn>
> Acked-by: Wei Dai <wei.dai@intel.com>
Applied to dpdk-next-net/master, thanks.
(datasheet references by Wei added into commit log)
parent reply other threads:[~2017-01-25 14:40 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <49759EB36A64CF4892C1AFEC9231E8D63A355A13@PGSMSX106.gar.corp.intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf29d4c9-6e72-f1cb-91ab-b9a1e577da38@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
--cc=wei.dai@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=yuanhan.liu@linux.intel.com \
--cc=zhang.yi75@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).