From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com,
niklas.soderlund@corigine.com, Long Wu <long.wu@corigine.com>,
James Hershaw <james.hershaw@corigine.com>
Subject: Re: [PATCH v4] net/bonding: replace master/slave to main/member
Date: Fri, 2 Jun 2023 16:05:20 +0100 [thread overview]
Message-ID: <bf44ef2b-1801-bb99-3ceb-64e7d008a3c7@amd.com> (raw)
In-Reply-To: <20230518083934.2b4ea341@hermes.local>
On 5/18/2023 4:39 PM, Stephen Hemminger wrote:
> On Thu, 18 May 2023 16:44:58 +0800
> Chaoyong He <chaoyong.he@corigine.com> wrote:
>
>> From: Long Wu <long.wu@corigine.com>
>>
>> This patch replaces the usage of the word 'master/slave' with more
>> appropriate word 'main/member' in bonding PMD as well as in its docs
>> and examples. Also the test app and testpmd were modified to use the
>> new wording.
>>
>> The bonding PMD's public API was modified according to the changes
>> in word:
>> rte_eth_bond_8023ad_slave_info is now called
>> rte_eth_bond_8023ad_member_info,
>> rte_eth_bond_active_slaves_get is now called
>> rte_eth_bond_active_members_get,
>> rte_eth_bond_slave_add is now called
>> rte_eth_bond_member_add,
>> rte_eth_bond_slave_remove is now called
>> rte_eth_bond_member_remove,
>> rte_eth_bond_slaves_get is now called
>> rte_eth_bond_members_get.
>>
>> Also the macro RTE_ETH_DEV_BONDED_SLAVE was renamed to
>> RTE_ETH_DEV_BONDED_MEMBER.
>>
>> Mark the old visible API's as deprecated and remove
>> from the ABI.
>>
>> Signed-off-by: Long Wu <long.wu@corigine.com>
>> Acked-by: Niklas Söderlund <niklas.soderlund@corigine.com>
>> Reviewed-by: James Hershaw <james.hershaw@corigine.com>
>
> Since this will be ABI change it will have to wait for 23.11 release.
> Could you make a deprecation notice now, to foreshadow that change?
>
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>
>
For reference, deprecation notice is:
https://patches.dpdk.org/project/dpdk/patch/20230519063334.1645933-1-chaoyong.he@corigine.com/
Deferring the patch to v23.11 release.
next prev parent reply other threads:[~2023-06-02 15:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 6:59 [PATCH] " Chaoyong He
2023-05-17 14:52 ` Stephen Hemminger
2023-05-18 3:26 ` Chaoyong He
2023-05-18 6:32 ` [PATCH v2] " Chaoyong He
2023-05-18 7:01 ` [PATCH v3] " Chaoyong He
2023-05-18 8:44 ` [PATCH v4] " Chaoyong He
2023-05-18 15:39 ` Stephen Hemminger
2023-06-02 15:05 ` Ferruh Yigit [this message]
2023-08-16 6:27 ` [PATCH v5 0/2] " Chaoyong He
2023-08-16 6:27 ` [PATCH v5 1/2] ethdev: remove bonding deprecated macro Chaoyong He
2023-08-17 2:28 ` lihuisong (C)
2023-08-16 6:27 ` [PATCH v5 2/2] net/bonding: replace master/slave to main/member Chaoyong He
2023-08-16 14:42 ` Stephen Hemminger
2023-08-17 2:36 ` lihuisong (C)
2023-08-18 2:44 ` [PATCH] app/test: fix reference to master in bonding test Stephen Hemminger
2023-08-21 15:59 ` Tyler Retzlaff
2023-09-21 16:10 ` Ferruh Yigit
2023-09-20 14:00 ` [PATCH v5 0/2] replace master/slave to main/member Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf44ef2b-1801-bb99-3ceb-64e7d008a3c7@amd.com \
--to=ferruh.yigit@amd.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=james.hershaw@corigine.com \
--cc=long.wu@corigine.com \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).