From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Wang, Xiao W" <xiao.w.wang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Guo, Jia" <jia.guo@intel.com>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Wang, Haiyue" <haiyue.wang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 0/8] ether: refine debug build option
Date: Tue, 23 Mar 2021 11:08:05 +0000 [thread overview]
Message-ID: <bf609aa2dd7442e095a99e5ea13c6874@intel.com> (raw)
In-Reply-To: <20210323110749.2306452-1-qi.z.zhang@intel.com>
Sorry, forgot adding change log....
v5:
- Remove RTE_ETHDEV_DEBUG
- Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG_RX|TX for backward compatibility.
v4:
- Alias RTE_LIBRTE_ETHDEV_DEBUG to RTE_ETHDEV_DEBUG in ethdev library
for backward compatibility.
- Not replace RTE_LIBRTE_ETHDEV_DEBUG in all PMDs.
v3:
- rename "RTE_LIBRTE_ETHDEV_xxx" to "RTE_ETHDEV_xxx"
- move document from "overview.rst" page to "build_and_test.rst"
- fix grammar issues.
v2:
- fix some coding style issues.
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Tuesday, March 23, 2021 7:08 PM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; thomas@monjalon.net; Richardson, Bruce
> <bruce.richardson@intel.com>; Wang, Xiao W <xiao.w.wang@intel.com>; Wu,
> Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Guo, Jia
> <jia.guo@intel.com>; Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH v5 0/8] ether: refine debug build option
>
> PMDs use RTE_LIBRTE_<PMD_NAME>_DEBUG_RX|TX as build option to wrap
> data path debug code. As .config has been removed since the meson build, It is
> not friendly for new DPDK users to notice those debug options.
>
> Patch 1/8: introduces new compile options for data path debug in ether layer,
> PMD can choose to reuse them to avoid maintain their own.
>
> - RTE_ETHDEV_DEBUG_RX
> - RTE_ETHDEV_DEBUG_TX
>
> The undocumented RTE_LIBRTE_ETHDEV_DEBUG will a alias to both
> RTE_ETHDEV_DEBUG_RX and RTE_ETHDEV_DEBUG_TX for backward
> compatibility.
>
> Patch 2/8 - 8/8: refine the build option for Intel PMDs by using the new build
> options
>
> Qi Zhang (8):
> ether: refine debug build option
> net/fm10k: refine debug build option
> net/e1000: refine debug build option
> net/i40e: refine debug build option
> net/iavf: refine debug build option
> net/ice: refine debug build option
> net/ixgbe: refine debug build option
> net/igc: refine debug build option
>
> doc/guides/nics/build_and_test.rst | 16 ++++++++
> drivers/net/e1000/e1000_logs.c | 17 ++------
> drivers/net/e1000/e1000_logs.h | 13 +-----
> drivers/net/e1000/em_rxtx.c | 38 +++++++++---------
> drivers/net/e1000/igb_rxtx.c | 2 +-
> drivers/net/fm10k/fm10k_ethdev.c | 7 +---
> drivers/net/fm10k/fm10k_logs.h | 13 +-----
> drivers/net/fm10k/fm10k_rxtx.c | 8 ++--
> drivers/net/i40e/i40e_ethdev.c | 7 +---
> drivers/net/i40e/i40e_logs.h | 13 +-----
> drivers/net/i40e/i40e_rxtx.c | 16 ++++----
> drivers/net/iavf/iavf_ethdev.c | 7 +---
> drivers/net/iavf/iavf_log.h | 13 +-----
> drivers/net/iavf/iavf_rxtx.c | 8 ++--
> drivers/net/ice/ice_ethdev.c | 7 +---
> drivers/net/ice/ice_logs.h | 13 +-----
> drivers/net/ice/ice_rxtx.c | 20 +++++-----
> drivers/net/igc/igc_logs.h | 4 +-
> drivers/net/igc/igc_txrx.c | 2 +-
> drivers/net/ixgbe/ixgbe_ethdev.c | 7 +---
> drivers/net/ixgbe/ixgbe_logs.h | 13 +-----
> drivers/net/ixgbe/ixgbe_rxtx.c | 64 +++++++++++++++---------------
> lib/librte_ethdev/rte_ethdev.h | 22 ++++++----
> 23 files changed, 137 insertions(+), 193 deletions(-)
>
> --
> 2.26.2
next prev parent reply other threads:[~2021-03-23 11:08 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 12:16 [dpdk-dev] [PATCH 0/8] ether: refine debug compile option Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 1/8] " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 2/8] net/fm10k: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 3/8] net/e1000: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 4/8] net/i40e: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 5/8] net/iavf: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 6/8] net/ice: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 7/8] net/ixgbe: " Qi Zhang
2021-03-10 12:16 ` [dpdk-dev] [PATCH 8/8] net/igc: " Qi Zhang
2021-03-10 12:35 ` [dpdk-dev] [PATCH 0/8] ether: " Ferruh Yigit
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 1/8] " Qi Zhang
2021-03-16 13:05 ` Ferruh Yigit
2021-03-16 13:39 ` Thomas Monjalon
2021-03-16 14:12 ` Bruce Richardson
2021-03-16 23:29 ` Zhang, Qi Z
2021-03-16 16:37 ` Ferruh Yigit
2021-03-22 17:24 ` Ferruh Yigit
2021-03-23 8:43 ` Zhang, Qi Z
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 2/8] net/fm10k: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 3/8] net/e1000: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 4/8] net/i40e: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 5/8] net/iavf: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 6/8] net/ice: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 7/8] net/ixgbe: " Qi Zhang
2021-03-12 12:12 ` [dpdk-dev] [PATCH v2 8/8] net/igc: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 0/9] ether: refine debug build option Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 1/9] " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 2/9] net: replace " Qi Zhang
2021-03-17 21:47 ` Ferruh Yigit
2021-03-17 22:00 ` Thomas Monjalon
2021-03-18 0:58 ` Zhang, Qi Z
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 3/9] net/fm10k: refine debug " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 4/9] net/e1000: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 5/9] net/i40e: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 6/9] net/iavf: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 7/9] net/ice: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 8/9] net/ixgbe: " Qi Zhang
2021-03-17 11:15 ` [dpdk-dev] [PATCH v3 9/9] net/igc: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 0/8] ether: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 1/8] " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 2/8] net/fm10k: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 3/8] net/e1000: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 4/8] net/i40e: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 5/8] net/iavf: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 6/8] net/ice: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 7/8] net/ixgbe: " Qi Zhang
2021-03-18 1:42 ` [dpdk-dev] [PATCH v4 8/8] net/igc: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 0/8] ether: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 1/8] " Qi Zhang
2021-03-23 14:44 ` Ferruh Yigit
2021-03-23 21:14 ` Thomas Monjalon
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 2/8] net/fm10k: " Qi Zhang
2021-03-23 14:45 ` Ferruh Yigit
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 3/8] net/e1000: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 4/8] net/i40e: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 5/8] net/iavf: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 6/8] net/ice: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 7/8] net/ixgbe: " Qi Zhang
2021-03-23 11:07 ` [dpdk-dev] [PATCH v5 8/8] net/igc: " Qi Zhang
2021-03-24 19:27 ` Ferruh Yigit
2021-03-24 20:31 ` David Marchand
2021-03-25 15:43 ` Ferruh Yigit
2021-03-30 14:06 ` Ferruh Yigit
2021-03-23 11:08 ` Zhang, Qi Z [this message]
2021-03-23 14:47 ` [dpdk-dev] [PATCH v5 0/8] ether: " Ferruh Yigit
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 1/8] " Qi Zhang
2021-04-01 14:30 ` Ferruh Yigit
2021-05-05 11:45 ` Ferruh Yigit
2021-05-05 12:21 ` Michał Krawczyk
2021-05-05 14:38 ` Ferruh Yigit
2021-05-06 11:09 ` [dpdk-dev] [EXT] " Rasesh Mody
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 2/8] net/fm10k: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 3/8] net/e1000: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 4/8] net/i40e: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 5/8] net/iavf: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 6/8] net/ice: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 7/8] net/ixgbe: " Qi Zhang
2021-03-31 9:52 ` [dpdk-dev] [PATCH v6 8/8] net/igc: " Qi Zhang
2021-04-01 14:11 ` [dpdk-dev] [PATCH v6 0/8] ether: " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf609aa2dd7442e095a99e5ea13c6874@intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=haiyue.wang@intel.com \
--cc=jia.guo@intel.com \
--cc=jingjing.wu@intel.com \
--cc=qiming.yang@intel.com \
--cc=thomas@monjalon.net \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).