From: Ferruh Yigit <ferruh.yigit@xilinx.com>
To: Chaoyong He <chaoyong.he@corigine.com>, <dev@dpdk.org>
Cc: <oss-drivers@corigine.com>, <niklas.soderlund@corigine.com>
Subject: Re: [PATCH v9 00/12] preparation for the rte_flow offload of nfp PMD
Date: Tue, 20 Sep 2022 15:56:18 +0100 [thread overview]
Message-ID: <c0140a42-2e94-8736-65f8-ffb549c6fa26@xilinx.com> (raw)
In-Reply-To: <1663238669-12244-1-git-send-email-chaoyong.he@corigine.com>
On 9/15/2022 11:44 AM, Chaoyong He wrote:
> * Changes since v8
> - Update the nfp.rst
> - Fix the 'app_hw' to 'app_fw'
> - Remove the ovs compatible header file
> - Remove the use of rte_eth_dev_configure()/rte_eth_rx_burst()/rte_eth_dev_start() API
>
> * Changes since v7
> - Adjust the logics to make sure not break the pci probe process
> - Change 'app' to 'app_fw' in all logics to avoid confuse
> - Fix problem about log level
>
> * Changes since v6
> - Fix the compile error
>
> * Changes since v5
> - Compare integer with 0 explicitly
> - Change helper macro to function
> - Implement the dummy functions
> - Remove some unnecessary logics
>
> * Changes since v4
> - Remove the unneeded '__rte_unused' attribute
> - Fixup a potential memory leak problem
>
> * Changes since v3
> - Add the 'Depends-on' tag
>
> * Changes since v2
> - Remove the use of rte_panic()
>
> * Changes since v1
> - Fix the compile error
>
> Depends-on: series-23707 ("Add support of NFP3800 chip and firmware with NFDk")
>
> Chaoyong He (12):
> net/nfp: move app specific attributes to own struct
> net/nfp: simplify initialization and remove dead code
> net/nfp: move app specific init logic to own function
> net/nfp: add initial flower firmware support
> net/nfp: add flower PF setup logic
> net/nfp: add flower PF related routines
> net/nfp: add flower ctrl VNIC related logics
> net/nfp: move common rxtx function for flower use
> net/nfp: add flower ctrl VNIC rxtx logic
> net/nfp: add flower representor framework
> net/nfp: move rxtx function to header file
> net/nfp: add flower PF rxtx logic
>
Hi Chaoyong,
Patchset looks good, except from two issues we have discussed before,
those issues are:
* Creating a new ethdev just for driver-FW control communication
* Application (OvS) specific code in the driver
I commented them separately and cc'ed more folks, we can proceed when
above are resolved.
Thanks,
ferruh
prev parent reply other threads:[~2022-09-20 14:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 10:44 Chaoyong He
2022-09-15 10:44 ` [PATCH v9 01/12] net/nfp: move app specific attributes to own struct Chaoyong He
2022-09-15 10:44 ` [PATCH v9 02/12] net/nfp: simplify initialization and remove dead code Chaoyong He
2022-09-15 10:44 ` [PATCH v9 03/12] net/nfp: move app specific init logic to own function Chaoyong He
2022-09-15 10:44 ` [PATCH v9 04/12] net/nfp: add initial flower firmware support Chaoyong He
2022-09-15 10:44 ` [PATCH v9 05/12] net/nfp: add flower PF setup logic Chaoyong He
2022-09-20 14:57 ` Ferruh Yigit
2022-09-21 2:50 ` Chaoyong He
2022-09-21 7:35 ` Thomas Monjalon
2022-09-21 7:47 ` Chaoyong He
2022-09-15 10:44 ` [PATCH v9 06/12] net/nfp: add flower PF related routines Chaoyong He
2022-09-15 10:44 ` [PATCH v9 07/12] net/nfp: add flower ctrl VNIC related logics Chaoyong He
2022-09-20 14:56 ` Ferruh Yigit
2022-09-21 2:02 ` Chaoyong He
2022-09-21 7:29 ` Thomas Monjalon
2022-09-21 7:42 ` Chaoyong He
2022-09-15 10:44 ` [PATCH v9 08/12] net/nfp: move common rxtx function for flower use Chaoyong He
2022-09-15 10:44 ` [PATCH v9 09/12] net/nfp: add flower ctrl VNIC rxtx logic Chaoyong He
2022-09-15 10:44 ` [PATCH v9 10/12] net/nfp: add flower representor framework Chaoyong He
2022-09-15 10:44 ` [PATCH v9 11/12] net/nfp: move rxtx function to header file Chaoyong He
2022-09-15 10:44 ` [PATCH v9 12/12] net/nfp: add flower PF rxtx logic Chaoyong He
2022-09-20 14:56 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0140a42-2e94-8736-65f8-ffb549c6fa26@xilinx.com \
--to=ferruh.yigit@xilinx.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=niklas.soderlund@corigine.com \
--cc=oss-drivers@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).