From: Ferruh Yigit <ferruh.yigit@amd.com>
To: David Marchand <david.marchand@redhat.com>, <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>
Subject: Re: [PATCH 0/6] Split driver specific commands out of testpmd
Date: Mon, 23 May 2022 19:09:16 +0100 [thread overview]
Message-ID: <c03b06a1-31e2-b9cc-dbab-1d753600ab11@amd.com> (raw)
In-Reply-To: <20220523071031.1868862-1-david.marchand@redhat.com>
On 5/23/2022 8:10 AM, David Marchand wrote:
> Hello,
>
> Following TB decision [1] and recent discussions on the driver specific
> commands in testpmd, here is a proposal on how the split could be done.
>
> For now, this series simply moves the testpmd code in the driver
> directory. The driver specific testpmd code is still compiled as part of
> testpmd compilation via a global meson testpmd_driver_sources list.
>
> Notes:
> - ixgbe bypass commands in testpmd were "dead" code since switch to meson,
> as the RTE_LIBRTE_IXGBE_BYPASS define is not set while compiling testpmd.
> No one complained about issue for the last two years, so those commands
> are dropped.
>
>
> 1:https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmails.dpdk.org%2Farchives%2Fdev%2F2022-April%2F239191.html&data=05%7C01%7Cferruh.yigit%40amd.com%7C14ffb5d174e04def3edd08da3c8b59be%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637888866467042882%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=XH8MQEiCmLkL%2FtX9BIaogwoaYLqy7ZrGAGQa7M7KM7A%3D&reserved=0
>
> --
> David Marchand
>
> Changes since RFC v2:
> - extended cleanup patch 1,
> - fixed command registration (again..),
> - dropped ixgbe bypass commands,
> - fixed some indent,
> - updated documentation,
>
> Changes since RFC v1:
> - added a cleanup as patch 1, to make all parser symbols static,
> - fixed registering issue in patch 1,
> - moved more i40e specific commands, fixed checkpatch warnings,
>
> David Marchand (6):
> app/testpmd: mark most cmdline symbols as static
> app/testpmd: register driver specific commands
> net/bonding: move testpmd commands
> net/i40e: move testpmd commands
> app/testpmd: drop ixgbe bypass commands
> net/ixgbe: move testpmd commands
+1 to split the PMD specific commands, and set lgtm. Thanks for the work.
next prev parent reply other threads:[~2022-05-23 18:09 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 7:57 [RFC PATCH 0/4] " David Marchand
2022-05-13 7:57 ` [RFC PATCH 1/4] app/testpmd: register driver specific commands David Marchand
2022-05-13 10:30 ` David Marchand
2022-05-13 7:57 ` [RFC PATCH 2/4] net/bonding: move testpmd commands David Marchand
2022-05-13 10:09 ` Min Hu (Connor)
2022-05-18 17:24 ` David Marchand
2022-05-18 23:25 ` Konstantin Ananyev
2022-05-19 7:40 ` David Marchand
2022-05-19 11:26 ` Thomas Monjalon
2022-05-20 6:59 ` Andrew Rybchenko
2022-05-24 9:40 ` Konstantin Ananyev
2022-05-24 10:15 ` Thomas Monjalon
2022-05-24 22:41 ` Konstantin Ananyev
2022-05-13 7:57 ` [RFC PATCH 3/4] net/i40e: " David Marchand
2022-05-13 7:57 ` [RFC PATCH 4/4] net/ixgbe: " David Marchand
2022-05-18 19:46 ` [RFC PATCH v2 0/5] Split driver specific commands out of testpmd David Marchand
2022-05-18 19:46 ` [RFC PATCH v2 1/5] app/testpmd: mark cmdline symbols as static David Marchand
2022-05-20 6:28 ` Andrew Rybchenko
2022-05-18 19:46 ` [RFC PATCH v2 2/5] app/testpmd: register driver specific commands David Marchand
2022-05-20 6:55 ` Andrew Rybchenko
2022-05-18 19:46 ` [RFC PATCH v2 3/5] net/bonding: move testpmd commands David Marchand
2022-05-20 6:55 ` Andrew Rybchenko
2022-05-18 19:46 ` [RFC PATCH v2 4/5] net/i40e: " David Marchand
2022-05-18 19:46 ` [RFC PATCH v2 5/5] net/ixgbe: " David Marchand
2022-05-20 7:04 ` [RFC PATCH v2 0/5] Split driver specific commands out of testpmd Andrew Rybchenko
2022-05-23 7:10 ` [PATCH 0/6] " David Marchand
2022-05-23 7:10 ` [PATCH 1/6] app/testpmd: mark most cmdline symbols as static David Marchand
2022-05-23 10:19 ` Dumitrescu, Cristian
2022-05-23 18:09 ` Ferruh Yigit
2022-05-23 7:10 ` [PATCH 2/6] app/testpmd: register driver specific commands David Marchand
2022-05-23 18:10 ` Ferruh Yigit
2022-05-24 10:53 ` David Marchand
2022-05-24 11:43 ` Ferruh Yigit
2022-05-24 17:21 ` Thomas Monjalon
2022-05-24 17:44 ` David Marchand
2022-05-24 17:51 ` Thomas Monjalon
2022-05-23 7:10 ` [PATCH 3/6] net/bonding: move testpmd commands David Marchand
2022-05-23 18:10 ` Ferruh Yigit
2022-06-17 5:06 ` [PATCH v2] " David Marchand
2022-06-20 17:53 ` Ferruh Yigit
2022-05-23 7:10 ` [PATCH 4/6] net/i40e: " David Marchand
2022-06-17 5:07 ` [PATCH v2] " David Marchand
2022-06-20 17:53 ` Ferruh Yigit
2022-05-23 7:10 ` [PATCH 5/6] app/testpmd: drop ixgbe bypass commands David Marchand
2022-05-23 18:10 ` Ferruh Yigit
2022-06-17 5:07 ` [PATCH v2 1/3] app/testpmd: restore " David Marchand
2022-06-17 5:07 ` [PATCH v2 2/3] net/ixgbe: move testpmd commands David Marchand
2022-06-17 5:07 ` [PATCH v2 3/3] net/ixgbe: move bypass init in a testpmd command David Marchand
2022-06-20 19:04 ` Ferruh Yigit
2022-06-23 12:35 ` Zhang, Qi Z
2022-07-21 8:05 ` [PATCH v3 1/3] app/testpmd: restore ixgbe bypass commands David Marchand
2022-07-21 8:05 ` [PATCH v3 2/3] net/ixgbe: move testpmd commands David Marchand
2022-07-21 8:05 ` [PATCH v3 3/3] net/ixgbe: move bypass init in a testpmd command David Marchand
2022-08-25 10:37 ` Ferruh Yigit
2022-08-25 11:44 ` [PATCH v3 1/3] app/testpmd: restore ixgbe bypass commands Ferruh Yigit
2022-05-23 7:10 ` [PATCH 6/6] net/ixgbe: move testpmd commands David Marchand
2022-05-23 18:09 ` Ferruh Yigit [this message]
2022-05-24 20:06 ` [PATCH v2 0/2] Split driver specific commands out of testpmd David Marchand
2022-05-24 20:06 ` [PATCH v2 1/2] app/testpmd: mark most cmdline symbols as static David Marchand
2022-05-31 15:15 ` Andrew Rybchenko
2022-05-24 20:06 ` [PATCH v2 2/2] app/testpmd: register driver specific commands David Marchand
2022-05-24 20:28 ` Thomas Monjalon
2022-05-31 15:14 ` Andrew Rybchenko
2022-05-31 15:18 ` David Marchand
2022-05-31 15:18 ` [PATCH v2 0/2] Split driver specific commands out of testpmd Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c03b06a1-31e2-b9cc-dbab-1d753600ab11@amd.com \
--to=ferruh.yigit@amd.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).