From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Shahaf Shuler" <shahafs@mellanox.com>,
"Adrien Mazarguil" <adrien.mazarguil@6wind.com>,
"Nélio Laranjeiro" <nelio.laranjeiro@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Raslan Darawsheh <rasland@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix PMD specific parameters defaults
Date: Wed, 19 Apr 2017 13:25:02 +0100 [thread overview]
Message-ID: <c0fcb05c-3f3c-b0a6-9a5a-4c5b77f53cf7@intel.com> (raw)
In-Reply-To: <AM4PR05MB1505C64D79FAEB559D64BAB9C3180@AM4PR05MB1505.eurprd05.prod.outlook.com>
On 4/19/2017 12:32 PM, Shahaf Shuler wrote:
> Wednesday, April 19, 2017 1:57 PM, Ferruh Yigit:
>> On 4/18/2017 11:22 AM, Shahaf Shuler wrote:
>>> With the Enhanced multi packet send addition, the defaults were made
>>> in order to get the maximum out of the box performance.
>>> Features like tso, don't use the enhanced send, however the defaults
>>> are still valid. This cause Tx queue creation to fail.
>>>
>>> Fixes: aea00c008140 ("net/mlx5: add hardware TSO support")
>>
>> Can you please confirm the Fixes line, the code modified below added with
>> commit [1], and above commit (correct one is: 3f13f8c23a7c) doesn't touch
>> those lines?
>
> Well I guess it can be either.
> The commit Fixes TSO because [1] caused TSO to fail on some cases.
> The commit Fixes multi-packet send since it is the one which caused the fault.
>
> Since you pointed that out, I guess other will follow your logic as well. So let's take you suggestion.
Does it make sense to add both?
> Do you need me to post a v3?
If you confirm, I can update while applying, not a new patch required.
>
>>
>> [1]
>> Fixes: 6ce84bd88919 ("net/mlx5: add enhanced multi-packet send for
>> ConnectX-5")
next prev parent reply other threads:[~2017-04-19 12:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-16 7:46 [dpdk-dev] [PATCH 1/2] net/mlx5: modify PMD args process Shahaf Shuler
2017-04-16 7:46 ` [dpdk-dev] [PATCH 2/2] net/mlx5: fix PMD specific parameters defaults Shahaf Shuler
2017-04-18 6:49 ` [dpdk-dev] [PATCH 1/2] net/mlx5: modify PMD args process Nélio Laranjeiro
2017-04-18 10:22 ` [dpdk-dev] [PATCH v2 " Shahaf Shuler
2017-04-18 10:22 ` [dpdk-dev] [PATCH v2 2/2] net/mlx5: fix PMD specific parameters defaults Shahaf Shuler
2017-04-19 10:57 ` Ferruh Yigit
2017-04-19 11:32 ` Shahaf Shuler
2017-04-19 12:25 ` Ferruh Yigit [this message]
2017-04-19 12:31 ` Shahaf Shuler
2017-04-19 6:50 ` [dpdk-dev] [PATCH v2 1/2] net/mlx5: modify PMD args process Nélio Laranjeiro
2017-04-19 12:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0fcb05c-3f3c-b0a6-9a5a-4c5b77f53cf7@intel.com \
--to=ferruh.yigit@intel.com \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=rasland@mellanox.com \
--cc=shahafs@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).