From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] use generated flags for SSE and AVX checks
Date: Tue, 15 Jan 2019 18:23:04 +0000 [thread overview]
Message-ID: <c194f45a-a688-57de-0c18-aea021b5fde2@intel.com> (raw)
In-Reply-To: <2241188.EjHfKBdCQS@xps13>
On 12/5/2016 3:59 PM, thomas.monjalon at 6wind.com (Thomas Monjalon) wrote:
> 2016-12-05 16:34, Thomas Monjalon:
>> Clean up the code to always use the flags RTE_MACHINE_CPUFLAG_*
>> generated by the DPDK makefile rte.cpuflags.mk.
>
> This patch does not work because RTE_MACHINE_CPUFLAG_* are generated
> for the whole library when including rte.vars.mk.
> So the flags are not accurate when overriding the flags per file like
> it is done in rte_acl.
>
> So the questions are:
> - should we use RTE_MACHINE_CPUFLAG_?
> - should we override the flags per file?
> - will we be able to use the function attribute __target__?
>
Hi Thomas,
This patch is waiting for a comment for two years, is it still valid, if not can
we mark it as rejected?
For record, it is: https://patches.dpdk.org/patch/17684/
Thanks,
ferruh
prev parent reply other threads:[~2019-01-15 18:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 15:34 Thomas Monjalon
2016-12-05 15:59 ` Thomas Monjalon
2019-01-15 18:23 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c194f45a-a688-57de-0c18-aea021b5fde2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).