From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yang, SteveX" <stevex.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix the RSS error when VF port closed
Date: Thu, 12 Nov 2020 11:47:44 +0000 [thread overview]
Message-ID: <c2076c4791a84e3b947232830f01adaa@intel.com> (raw)
In-Reply-To: <20201109065136.26807-3-stevex.yang@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Steve Yang
> Sent: Monday, November 9, 2020 2:52 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>
> Subject: [dpdk-dev] [PATCH v2 2/2] net/iavf: fix the RSS error when VF port
> closed
>
> Check the VF RSS offload flag and ignore relative operation when iavf hash
> uninit to avoid reset/close error.
>
> Fixes: 7be10c3004be ("net/iavf: add RSS configuration for VF")
>
> Signed-off-by: Steve Yang <stevex.yang@intel.com>
> ---
> drivers/net/iavf/iavf_hash.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index
> 8a5a6bb5a4..d3e9218f75 100644
> --- a/drivers/net/iavf/iavf_hash.c
> +++ b/drivers/net/iavf/iavf_hash.c
> @@ -1093,10 +1093,13 @@ iavf_hash_uninit(struct iavf_adapter *ad)
> if (vf->vf_reset)
> return;
>
> - if (iavf_hash_default_set(ad, false))
> - PMD_DRV_LOG(ERR, "fail to delete default RSS");
> + if (vf->vf_res &&
> + vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_ADV_RSS_PF) {
> + if (iavf_hash_default_set(ad, false))
> + PMD_DRV_LOG(ERR, "fail to delete default RSS");
Better to follow the same pattern in ice_hash_init, return immediate when check something wrong.
>
> - iavf_unregister_parser(&iavf_hash_parser, ad);
> + iavf_unregister_parser(&iavf_hash_parser, ad);
> + }
> }
>
> static void
> --
> 2.17.1
next prev parent reply other threads:[~2020-11-12 11:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 8:32 [dpdk-dev] [PATCH v1] net/iavf: fix reset VF doesn't notify PF to reset Steve Yang
2020-11-06 2:58 ` Xing, Beilei
2020-11-09 6:51 ` [dpdk-dev] [PATCH v2 0/2] net/iavf: backported bug fixes from i40evf to iavf Steve Yang
2020-11-09 6:51 ` [dpdk-dev] [PATCH v2 1/2] net/iavf: fix reset VF doesn't notify PF to reset Steve Yang
2020-11-10 5:56 ` Xing, Beilei
2020-11-09 6:51 ` [dpdk-dev] [PATCH v2 2/2] net/iavf: fix the RSS error when VF port closed Steve Yang
2020-11-12 11:47 ` Zhang, Qi Z [this message]
2020-11-13 0:46 ` [dpdk-dev] [PATCH v2 0/2] net/iavf: backported bug fixes from i40evf to iavf Steve Yang
2020-11-13 0:46 ` [dpdk-dev] [PATCH v3 1/2] net/iavf: fix reset VF doesn't notify PF to reset Steve Yang
2020-11-13 7:45 ` Xing, Beilei
2020-11-13 0:46 ` [dpdk-dev] [PATCH v3 2/2] net/iavf: fix the RSS error when VF port closed Steve Yang
2020-11-13 5:38 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2076c4791a84e3b947232830f01adaa@intel.com \
--to=qi.z.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).