From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/bnxt: switch to the new offload API
Date: Thu, 5 Apr 2018 15:36:00 +0100 [thread overview]
Message-ID: <c24aa2f2-0bf3-9ee5-5945-7f7a6b191da5@intel.com> (raw)
In-Reply-To: <20180402222501.62165-1-ajit.khaparde@broadcom.com>
On 4/2/2018 11:25 PM, Ajit Khaparde wrote:
> Update bnxt PMD to new ethdev offloads API.
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> --
> v1->v2: return an error if requested offload flags do not
> match supported offload capabilities.
> v2->v3: modify the code based on review comments.
<...>
> @@ -516,6 +526,20 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
> static int bnxt_dev_configure_op(struct rte_eth_dev *eth_dev)
> {
> struct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private;
> + uint64_t tx_offloads = eth_dev->data->dev_conf.txmode.offloads;
> + uint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads;
> +
> + if (tx_offloads != (tx_offloads & BNXT_DEV_TX_OFFLOAD_SUPPORT)) {
> + PMD_DRV_LOG(ERR, "Tx offloads requested 0x%lx supported 0x%x\n",
> + tx_offloads, BNXT_DEV_TX_OFFLOAD_SUPPORT);
> + return -ENOTSUP;
> + }
> +
> + if (rx_offloads != (rx_offloads & BNXT_DEV_RX_OFFLOAD_SUPPORT)) {
> + PMD_DRV_LOG(ERR, "Rx offloads requested 0x%lx supported 0x%x\n",
> + rx_offloads, BNXT_DEV_RX_OFFLOAD_SUPPORT);
> + return -ENOTSUP;
> + }
This is causing i686 build error [1].
[1]
In file included from .../dpdk/drivers/net/bnxt/bnxt_ethdev.c:43:0:
.../dpdk/drivers/net/bnxt/bnxt_ethdev.c: In function ‘bnxt_dev_configure_op’:
.../dpdk/drivers/net/bnxt/bnxt.h:341:50: error: format ‘%lx’ expects argument of
type ‘long unsigned int’, but argument 5 has type ‘uint64_t {aka long long
unsigned int}’ [-Werror=format=]
rte_log(RTE_LOG_ ## level, bnxt_logtype_driver, "%s(): " fmt, \
^
.../dpdk/drivers/net/bnxt/bnxt.h:345:2: note: in expansion of macro
‘PMD_DRV_LOG_RAW’
PMD_DRV_LOG_RAW(level, fmt, ## args)
^~~~~~~~~~~~~~~
.../dpdk/drivers/net/bnxt/bnxt_ethdev.c:528:3: note: in expansion of macro
‘PMD_DRV_LOG’
PMD_DRV_LOG(ERR, "Tx offloads requested 0x%lx supported 0x%x\n",
^~~~~~~~~~~
.../dpdk/drivers/net/bnxt/bnxt_ethdev.c:528:47: note: format string is defined here
PMD_DRV_LOG(ERR, "Tx offloads requested 0x%lx supported 0x%x\n",
~~^
%llx
In file included from .../dpdk/drivers/net/bnxt/bnxt_ethdev.c:43:0:
.../dpdk/drivers/net/bnxt/bnxt.h:341:50: error: format ‘%lx’ expects argument of
type ‘long unsigned int’, but argument 5 has type ‘uint64_t {aka long long
unsigned int}’ [-Werror=format=]
rte_log(RTE_LOG_ ## level, bnxt_logtype_driver, "%s(): " fmt, \
^
.../dpdk/drivers/net/bnxt/bnxt.h:345:2: note: in expansion of macro
‘PMD_DRV_LOG_RAW’
PMD_DRV_LOG_RAW(level, fmt, ## args)
^~~~~~~~~~~~~~~
.../dpdk/drivers/net/bnxt/bnxt_ethdev.c:534:3: note: in expansion of macro
‘PMD_DRV_LOG’
PMD_DRV_LOG(ERR, "Rx offloads requested 0x%lx supported 0x%x\n",
^~~~~~~~~~~
.../dpdk/drivers/net/bnxt/bnxt_ethdev.c:534:47: note: format string is defined here
PMD_DRV_LOG(ERR, "Rx offloads requested 0x%lx supported 0x%x\n",
~~^
%llx
cc1: all warnings being treated as errors
next prev parent reply other threads:[~2018-04-05 14:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 19:40 [dpdk-dev] [PATCH] " Ajit Khaparde
2018-03-21 19:08 ` Ferruh Yigit
2018-03-21 19:27 ` Ajit Khaparde
2018-03-22 6:22 ` Shahaf Shuler
2018-03-26 22:47 ` [dpdk-dev] [PATCH v2] " Ajit Khaparde
2018-03-30 10:38 ` Ferruh Yigit
2018-04-02 22:25 ` [dpdk-dev] [PATCH v3 1/2] " Ajit Khaparde
2018-04-02 22:25 ` [dpdk-dev] [PATCH v3 2/2] net/bnxt: fix rx_drop_en setting Ajit Khaparde
2018-04-05 14:36 ` Ferruh Yigit [this message]
2018-04-06 0:22 ` [dpdk-dev] [PATCH v4 1/2] " Ajit Khaparde
2018-04-06 0:22 ` [dpdk-dev] [PATCH v4 2/2] net/bnxt: switch to the new offload API Ajit Khaparde
2018-04-06 15:11 ` Ferruh Yigit
2018-04-07 17:40 ` [dpdk-dev] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting Ajit Khaparde
2018-04-07 17:40 ` [dpdk-dev] [PATCH v5 2/2] net/bnxt: switch to the new offload API Ajit Khaparde
2018-04-09 16:53 ` [dpdk-dev] [dpdk-stable] [PATCH v5 1/2] net/bnxt: fix rx_drop_en setting Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c24aa2f2-0bf3-9ee5-5945-7f7a6b191da5@intel.com \
--to=ferruh.yigit@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).