From: Luca Boccassi <bluca@debian.org>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: pablo.de.lara.guarch@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: add dependency version check
Date: Wed, 24 Apr 2019 11:52:23 +0100 [thread overview]
Message-ID: <c2ba9ed7a98691372094f070792f3dfd3871c05f.camel@debian.org> (raw)
In-Reply-To: <20190424103857.GA1885@bricha3-MOBL.ger.corp.intel.com>
On Wed, 2019-04-24 at 11:38 +0100, Bruce Richardson wrote:
> On Wed, Apr 24, 2019 at 10:19:20AM +0100, Luca Boccassi wrote:
> > On Tue, 2019-04-23 at 16:43 +0100, Bruce Richardson wrote:
> > > The aesni_mb driver and the aesni_gcm driver both require the
> > > same
> > > version
> > > of the IPSec_MB library, but only the former has a check of the
> > > library
> > > found by meson to see if it's the correct version. Add a similar
> > > check to
> > > the aesni_gcm library's meson.build file, so that the auto-
> > > detection
> > > of
> > > dependencies works correctly.
> > >
> > > Signed-off-by: Bruce Richardson <
> > > bruce.richardson@intel.com
> > >
> > >
> > > ---
> > > drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++
> > > 1 file changed, 11 insertions(+)
> > >
> > > diff --git a/drivers/crypto/aesni_gcm/meson.build
> > > b/drivers/crypto/aesni_gcm/meson.build
> > > index 70f57ad73..7183cfcba 100644
> > > --- a/drivers/crypto/aesni_gcm/meson.build
> > > +++ b/drivers/crypto/aesni_gcm/meson.build
> > > @@ -1,11 +1,22 @@
> > > # SPDX-License-Identifier: BSD-3-Clause
> > > # Copyright(c) 2018 Intel Corporation
> > >
> > > +IMB_required_ver = '0.52.0'
> > > lib = cc.find_library('IPSec_MB', required: false)
> > > if not lib.found()
> > > build = false
> > > else
> > > ext_deps += lib
> >
> > Shouldn't this be moved into a new else branch after the version
> > check?
> >
>
> No, it's harmless where it is, since if build is set to false, the
> values
> set for sources, deps etc. are all ignored and reset for building the
> next
> driver in the list.
>
> /Bruce
Ah I see, thanks
--
Kind regards,
Luca Boccassi
next prev parent reply other threads:[~2019-04-24 10:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 15:43 [dpdk-dev] [PATCH v2 0/3] improve IPsec_MB dependency checks Bruce Richardson
2019-04-23 15:43 ` Bruce Richardson
2019-04-23 15:43 ` [dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: add dependency version check Bruce Richardson
2019-04-23 15:43 ` Bruce Richardson
2019-04-24 7:53 ` De Lara Guarch, Pablo
2019-04-24 7:53 ` De Lara Guarch, Pablo
2019-04-24 9:19 ` Luca Boccassi
2019-04-24 9:19 ` Luca Boccassi
2019-04-24 10:38 ` Bruce Richardson
2019-04-24 10:38 ` Bruce Richardson
2019-04-24 10:52 ` Luca Boccassi [this message]
2019-04-24 10:52 ` Luca Boccassi
2019-04-23 15:43 ` [dpdk-dev] [PATCH v2 2/3] crypto/aesni_mb: cleanup of version check code Bruce Richardson
2019-04-23 15:43 ` Bruce Richardson
2019-04-23 15:43 ` [dpdk-dev] [PATCH v2 3/3] crypto/aesni_gcm: add check for build dependency Bruce Richardson
2019-04-23 15:43 ` Bruce Richardson
2019-04-24 7:53 ` De Lara Guarch, Pablo
2019-04-24 7:53 ` De Lara Guarch, Pablo
2019-04-24 10:52 ` [dpdk-dev] [PATCH v2 0/3] improve IPsec_MB dependency checks Luca Boccassi
2019-04-24 10:52 ` Luca Boccassi
2019-04-30 6:48 ` Akhil Goyal
2019-04-30 6:48 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2ba9ed7a98691372094f070792f3dfd3871c05f.camel@debian.org \
--to=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).