From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Wang, Xiao W" <xiao.w.wang@intel.com>,
Julien Meunier <julien.meunier@nokia.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [PATCH] net/fm10k: initialize sm_down variable
Date: Fri, 4 Jan 2019 17:34:54 +0000 [thread overview]
Message-ID: <c3222c29-0036-5b97-8262-722560880ae2@intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E706115331488F@SHSMSX103.ccr.corp.intel.com>
On 1/4/2019 1:04 PM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Wang, Xiao W
>> Sent: Thursday, January 3, 2019 10:10 AM
>> To: Julien Meunier <julien.meunier@nokia.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: RE: [PATCH] net/fm10k: initialize sm_down variable
>>
>> Hi Julien,
>>
>>> -----Original Message-----
>>> From: Julien Meunier [mailto:julien.meunier@nokia.com]
>>> Sent: Wednesday, January 2, 2019 11:58 PM
>>> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Xiao W
>>> <xiao.w.wang@intel.com>
>>> Cc: dev@dpdk.org; stable@dpdk.org
>>> Subject: [PATCH] net/fm10k: initialize sm_down variable
>>>
>>> Fixes: 6f22f2f67268 ("net/fm10k: redefine link status semantics")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Julien Meunier <julien.meunier@nokia.com>
>>> ---
>>> drivers/net/fm10k/fm10k_ethdev.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/fm10k/fm10k_ethdev.c
>>> b/drivers/net/fm10k/fm10k_ethdev.c
>>> index 85fb6c5..caf4d1b 100644
>>> --- a/drivers/net/fm10k/fm10k_ethdev.c
>>> +++ b/drivers/net/fm10k/fm10k_ethdev.c
>>> @@ -3003,6 +3003,7 @@ fm10k_params_init(struct rte_eth_dev *dev)
>>> hw->bus.payload = fm10k_bus_payload_256;
>>>
>>> info->rx_vec_allowed = true;
>>> + info->sm_down = false;
>>> }
>>>
>>> static int
>>> --
>>> 2.10.2
>>
>> Acked-by: Xiao Wang <xiao.w.wang@intel.com>
>
> Applied to dpdk-next-net-intel.
Is it possible to add more information to commit log?
What happens if "sm_down" is not initialized? What "sm_down" is for?
Should patch title be a 'fix' patch?
next prev parent reply other threads:[~2019-01-04 17:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 15:57 Julien Meunier
2019-01-03 2:09 ` Wang, Xiao W
2019-01-04 13:04 ` Zhang, Qi Z
2019-01-04 17:34 ` Ferruh Yigit [this message]
2019-01-07 16:18 ` Meunier, Julien (Nokia - FR/Paris-Saclay)
2019-01-08 10:19 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3222c29-0036-5b97-8262-722560880ae2@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=julien.meunier@nokia.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).