From: Markos Chandras <mchandras@suse.de>
To: Nirmoy Das <ndas@suse.de>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] pci: fix glibc 2.25 warning regarding major/minor definitions
Date: Tue, 4 Apr 2017 13:50:06 +0100 [thread overview]
Message-ID: <c374f56f-53ac-4f67-09cd-504aff076c61@suse.de> (raw)
In-Reply-To: <20170404123211.5185-1-ndas@suse.de>
Hi Nirmoy,
On 04/04/2017 01:32 PM, Nirmoy Das wrote:
> fixes:
> error: In the GNU C Library, "makedev" is defined
> by <sys/sysmacros.h>. For historical compatibility, it is
> currently defined by <sys/types.h> as well, but we plan to
> remove this soon. To use "makedev", include <sys/sysmacros.h>
> directly. If you did not intend to use a system-defined macro
> "makedev", you should undefine it after including <sys/types.h>. [-Werror]
> dev = makedev(major, minor);
>
You forgot the 'Signed-off-by' line which is required for patches.
See doc/guides/contributing/patches.rst
--
markos
SUSE LINUX GmbH | GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg) Maxfeldstr. 5, D-90409, Nürnberg
next prev parent reply other threads:[~2017-04-04 12:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 12:32 Nirmoy Das
2017-04-04 12:50 ` Markos Chandras [this message]
2017-04-04 12:50 ` Markos Chandras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c374f56f-53ac-4f67-09cd-504aff076c61@suse.de \
--to=mchandras@suse.de \
--cc=dev@dpdk.org \
--cc=ndas@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).