From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [dpdk-dev] [PATCH] netvsc: support multicast/promiscuous settings on VF
Date: Mon, 24 Sep 2018 16:49:24 +0100 [thread overview]
Message-ID: <c43b1194-9c54-19a0-92b2-090664286f01@intel.com> (raw)
In-Reply-To: <20180921165425.18168-1-stephen@networkplumber.org>
On 9/21/2018 5:54 PM, Stephen Hemminger wrote:
> Provide API's to enable allmulticast and promiscuous in Netvsc PMD
> with VF. This keeps the VF and PV path in sync.
VF and PF?
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> ---
> Patch against dpdk-net-next
>
> drivers/net/netvsc/hn_ethdev.c | 14 +++++++++++++
> drivers/net/netvsc/hn_var.h | 9 +++++++++
> drivers/net/netvsc/hn_vf.c | 37 ++++++++++++++++++++++++++++++++++
> 3 files changed, 60 insertions(+)
>
> diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
> index b67cce1ba8f5..3092066ada36 100644
> --- a/drivers/net/netvsc/hn_ethdev.c
> +++ b/drivers/net/netvsc/hn_ethdev.c
> @@ -255,6 +255,7 @@ hn_dev_promiscuous_enable(struct rte_eth_dev *dev)
> struct hn_data *hv = dev->data->dev_private;
>
> hn_rndis_set_rxfilter(hv, NDIS_PACKET_TYPE_PROMISCUOUS);
> + hn_vf_promiscuous_enable(dev);
This VF approach is confusing to me, is this calling a underlay device a VF device?
<...>
> +static int
> +hn_dev_mc_addr_list(struct rte_eth_dev *dev,
> + struct ether_addr *mc_addr_set,
> + uint32_t nb_mc_addr)
Just to double check, this dev_ops to add MAC multicast filters, to add MAC
filters it is mac_addr_set, mac_addr_add, mac_addr_remove. Many HW seems can set
the multicast MAC filters via "mac_addr_add" too.
If this is the intention please enable "Multicast MAC filter" in netvsc.ini
next prev parent reply other threads:[~2018-09-24 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 16:54 Stephen Hemminger
2018-09-24 15:49 ` Ferruh Yigit [this message]
2018-09-25 8:49 ` Stephen Hemminger
2018-10-01 14:02 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c43b1194-9c54-19a0-92b2-090664286f01@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).