From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com
Subject: Re: [PATCH v3 7/7] baseband/acc: acc100 ignore missing mempools
Date: Tue, 17 Jan 2023 11:50:22 +0100 [thread overview]
Message-ID: <c5dc6c6f-94e8-30be-1cb5-24c1ecbcba5d@redhat.com> (raw)
In-Reply-To: <20230112193609.273578-8-hernan.vargas@intel.com>
On 1/12/23 20:36, Hernan Vargas wrote:
> Mempool not strictly required to be present in op for processing.
> Previous criteria too strict. No functional impact.
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
> drivers/baseband/acc/rte_acc100_pmd.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> index d3aaeb8f2c..0992cb5d1e 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -8,7 +8,6 @@
> #include <rte_log.h>
> #include <dev_driver.h>
> #include <rte_malloc.h>
> -#include <rte_mempool.h>
> #include <rte_byteorder.h>
> #include <rte_errno.h>
> #include <rte_branch_prediction.h>
> @@ -1830,10 +1829,6 @@ validate_enc_op(struct rte_bbdev_enc_op *op, struct acc_queue *q)
> if (!validate_op_required(q))
> return 0;
>
> - if (op->mempool == NULL) {
> - rte_bbdev_log(ERR, "Invalid mempool pointer");
> - return -1;
> - }
> if (turbo_enc->input.data == NULL) {
> rte_bbdev_log(ERR, "Invalid input pointer");
> return -1;
> @@ -2677,10 +2672,6 @@ validate_dec_op(struct rte_bbdev_dec_op *op, struct acc_queue *q)
> if (!validate_op_required(q))
> return 0;
>
> - if (op->mempool == NULL) {
> - rte_bbdev_log(ERR, "Invalid mempool pointer");
> - return -1;
> - }
> if (turbo_dec->input.data == NULL) {
> rte_bbdev_log(ERR, "Invalid input pointer");
> return -1;
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2023-01-17 10:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 19:36 [PATCH v3 0/7] baseband/acc: changes for 23.03 Hernan Vargas
2023-01-12 19:36 ` [PATCH v3 1/7] baseband/acc: acc100 free harq layout pointer Hernan Vargas
2023-01-17 10:49 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 2/7] baseband/acc: acc100 fix iteration counter in TB Hernan Vargas
2023-01-17 10:49 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 3/7] baseband/acc: acc100 fix multiplexing multiple ops Hernan Vargas
2023-01-17 10:49 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 4/7] baseband/acc: acc100 fix queue mapping to 64 bits Hernan Vargas
2023-01-17 10:49 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 5/7] baseband/acc: acc100 use define constant Hernan Vargas
2023-01-17 10:50 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 6/7] baseband/acc: acc100 use desc helper functions Hernan Vargas
2023-01-17 10:50 ` Maxime Coquelin
2023-01-12 19:36 ` [PATCH v3 7/7] baseband/acc: acc100 ignore missing mempools Hernan Vargas
2023-01-17 10:50 ` Maxime Coquelin [this message]
2023-01-17 10:49 ` [PATCH v3 0/7] baseband/acc: changes for 23.03 Maxime Coquelin
2023-01-19 10:06 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5dc6c6f-94e8-30be-1cb5-24c1ecbcba5d@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).