From: Ferruh Yigit <ferruh.yigit@amd.com>
To: Huisong Li <lihuisong@huawei.com>, dev@dpdk.org, thomas@monjalon.net
Cc: liuyonglong@huawei.com
Subject: Re: [PATCH v3 0/6] doc/features: fix some features and add new features
Date: Mon, 27 Nov 2023 12:35:53 +0000 [thread overview]
Message-ID: <c6226ed9-03ac-41ee-984e-15849aa5a9f3@amd.com> (raw)
In-Reply-To: <20231125014745.61348-1-lihuisong@huawei.com>
On 11/25/2023 1:47 AM, Huisong Li wrote:
> The support for setting RSS hash algorithm has been introduced to 23.11,
> but doesn't add feature for it. So this series add this feature and perfect
> RSS other features by the way.
>
> In addition, serval features, like "set link up/down", "TM", "dump device
> private information" and "loopback mode", had beed supported, but they are
> absent from the freatures list.
>
> ---
> -v3:
> - fix description of the patchset cover
> - remove '/features' in 'doc/features' tag for every patch.
> - add Acked-by: Chengwen Feng <fengchengwen@huawei.com>
> - retrigger CI build because of wrong CI warning
>
> -v2:
> - add loopback mode feature.
>
> Huisong Li (6):
> doc: add RSS hash algorithm feature
> doc: add link up/down feature
> doc: add features for link speeds
> doc: add Traffic Manager feature
> doc: add dump device private information feature
> doc: add feature for loopback mode
>
>
Hi Huisong,
Some of the patches above adds new features to the 'features.rst', but
features.rst document describes features that drivers mark in feature
list in .ini file, all features are listed in the 'default.ini'.
When a new feature is added into 'default.ini', it can be described in
'features.rst' and later all driver .ini files should be updated to
reflect if they support this feature or not.
And I think no need to document all features, but ones can be important
enough or differentiating features for users to know, this line is not
easy to draw, so perhaps we can use community consensus to select.
In this patch following features are added:
- Link speed configuration
- Traffic manager
- Device private information dump
- Loopback configuration
I think 'Traffic manager' can be a new feature, but I am not sure about
rest. It would be nice to get more comments.
next prev parent reply other threads:[~2023-11-27 12:36 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-23 13:59 [PATCH 0/5] " Huisong Li
2023-11-23 13:59 ` [PATCH 1/5] doc/features: add RSS hash algorithm feature Huisong Li
2023-11-23 13:59 ` [PATCH 2/5] doc/features: add link up/down feature Huisong Li
2023-11-23 13:59 ` [PATCH 3/5] doc/features: add config interface for speed capabilities Huisong Li
2023-11-23 13:59 ` [PATCH 4/5] doc/features: add Traffic Manager features Huisong Li
2023-11-23 13:59 ` [PATCH 5/5] doc/features: add dump device private information feature Huisong Li
2023-11-23 14:18 ` Thomas Monjalon
2023-11-24 2:03 ` lihuisong (C)
2023-11-24 3:12 ` [PATCH 0/6] doc/features: fix some features and add new features Huisong Li
2023-11-24 3:12 ` [PATCH 1/6] doc/features: add RSS hash algorithm feature Huisong Li
2023-11-24 3:12 ` [PATCH 2/6] doc/features: add link up/down feature Huisong Li
2023-11-24 3:12 ` [PATCH 3/6] doc/features: add features for link speeds Huisong Li
2023-11-24 3:12 ` [PATCH 4/6] doc/features: add Traffic Manager features Huisong Li
2023-11-24 3:12 ` [PATCH 5/6] doc/features: add dump device private information feature Huisong Li
2023-11-24 3:12 ` [PATCH 6/6] doc/features: add feature for loopback mode Huisong Li
2023-11-24 3:24 ` [PATCH 0/6] doc/features: fix some features and add new features fengchengwen
2023-11-25 1:47 ` [PATCH v3 " Huisong Li
2023-11-25 1:47 ` [PATCH v3 1/6] doc: add RSS hash algorithm feature Huisong Li
2023-11-27 12:19 ` Ferruh Yigit
2023-11-27 13:12 ` lihuisong (C)
2023-11-27 15:43 ` Ferruh Yigit
2023-11-27 16:35 ` Ferruh Yigit
2023-11-28 1:34 ` lihuisong (C)
2023-11-28 10:23 ` Ferruh Yigit
2023-11-28 1:21 ` lihuisong (C)
2023-11-28 10:09 ` Ferruh Yigit
2023-11-28 11:29 ` lihuisong (C)
2023-11-28 11:52 ` Ferruh Yigit
2023-11-28 12:46 ` lihuisong (C)
2023-11-25 1:47 ` [PATCH v3 2/6] doc: add link up/down feature Huisong Li
2023-11-27 12:24 ` Ferruh Yigit
2023-11-27 13:16 ` lihuisong (C)
2023-11-25 1:47 ` [PATCH v3 3/6] doc: add features for link speeds Huisong Li
2023-11-25 1:47 ` [PATCH v3 4/6] doc: add Traffic Manager feature Huisong Li
2023-11-25 1:47 ` [PATCH v3 5/6] doc: add dump device private information feature Huisong Li
2023-11-25 1:47 ` [PATCH v3 6/6] doc: add feature for loopback mode Huisong Li
2023-11-27 12:35 ` Ferruh Yigit [this message]
2023-11-27 13:37 ` [PATCH v3 0/6] doc/features: fix some features and add new features lihuisong (C)
2023-11-27 16:19 ` Ferruh Yigit
2023-11-27 14:16 ` [PATCH v4 0/5] " Huisong Li
2023-11-27 14:16 ` [PATCH v4 1/5] doc: fix the description of RSS related feature Huisong Li
2023-11-27 16:36 ` Ferruh Yigit
2023-11-27 14:16 ` [PATCH v4 2/5] doc: add link up/down feature Huisong Li
2023-11-27 14:16 ` [PATCH v4 3/5] doc: add features for link speeds Huisong Li
2023-11-27 14:16 ` [PATCH v4 4/5] doc: add Traffic Manager feature Huisong Li
2023-11-27 14:16 ` [PATCH v4 5/5] doc: add dump device private information ops Huisong Li
2023-11-27 16:37 ` Ferruh Yigit
2023-11-27 16:44 ` [PATCH v4 0/5] doc/features: fix some features and add new features Ferruh Yigit
2023-11-28 2:09 ` lihuisong (C)
2023-11-28 4:07 ` lihuisong (C)
2023-11-27 16:56 ` Ferruh Yigit
2023-11-28 2:23 ` lihuisong (C)
2023-11-28 5:59 ` [PATCH v5 0/3] " Huisong Li
2023-11-28 5:59 ` [PATCH v5 1/3] doc: fix the description of RSS related feature Huisong Li
2023-11-28 13:54 ` Thomas Monjalon
2023-11-28 5:59 ` [PATCH v5 2/3] doc: add link up/down feature Huisong Li
2023-11-28 5:59 ` [PATCH v5 3/3] doc: add dump device private information ops Huisong Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6226ed9-03ac-41ee-984e-15849aa5a9f3@amd.com \
--to=ferruh.yigit@amd.com \
--cc=dev@dpdk.org \
--cc=lihuisong@huawei.com \
--cc=liuyonglong@huawei.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).