From: Ferruh Yigit <ferruh.yigit@amd.com>
To: "Ande, Venkat Kumar" <VenkatKumar.Ande@amd.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Sebastian, Selwin" <Selwin.Sebastian@amd.com>
Subject: Re: [PATCH v1] net/axgbe: read and save the port property register
Date: Tue, 9 Jan 2024 18:07:50 +0000 [thread overview]
Message-ID: <c62995c6-0ddc-4656-8eac-3eeb94ad1c29@amd.com> (raw)
In-Reply-To: <DM4PR12MB51043238766F8388EE6A461F9E6A2@DM4PR12MB5104.namprd12.prod.outlook.com>
On 1/9/2024 11:14 AM, Ande, Venkat Kumar wrote:
> [AMD Official Use Only - General]
>
> Hi Ferruh,
>
> This change will be refactoring for future code readability of AMD AXGBE driver.
>
Thanks for clarification, I can update commit log with this info while
merging.
> Regards,
> Venkat
>
> -----Original Message-----
> From: Yigit, Ferruh <Ferruh.Yigit@amd.com>
> Sent: Tuesday, January 9, 2024 4:05 PM
> To: Ande, Venkat Kumar <VenkatKumar.Ande@amd.com>; dev@dpdk.org
> Cc: Sebastian, Selwin <Selwin.Sebastian@amd.com>
> Subject: Re: [PATCH v1] net/axgbe: read and save the port property register
>
> On 1/5/2024 11:32 AM, Venkat Kumar Ande wrote:
>> From: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
>>
>> Read and save the port property registers once during the device probe
>> and then use the saved values as they are needed.
>>
>
> Hi Venkat,
>
> Can you please describe what is the motivation/reason for the change?
>
> Is it addressing a functional problem or refactoring for coming feature etc...?
>
>> Signed-off-by: Venkat Kumar Ande <VenkatKumar.Ande@amd.com>
>> ---
>> drivers/net/axgbe/axgbe_ethdev.c | 21 +++++----
>> drivers/net/axgbe/axgbe_ethdev.h | 7 +++
>> drivers/net/axgbe/axgbe_phy_impl.c | 68
>> ++++++++++++------------------
>> 3 files changed, 48 insertions(+), 48 deletions(-)
>>
>> diff --git a/drivers/net/axgbe/axgbe_ethdev.c
>> b/drivers/net/axgbe/axgbe_ethdev.c
>> index f174d46143..3450374535 100644
>> --- a/drivers/net/axgbe/axgbe_ethdev.c
>> +++ b/drivers/net/axgbe/axgbe_ethdev.c
>> @@ -2342,23 +2342,28 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)
>> pdata->arcache = AXGBE_DMA_OS_ARCACHE;
>> pdata->awcache = AXGBE_DMA_OS_AWCACHE;
>>
>> + /* Read the port property registers */
>> + pdata->pp0 = XP_IOREAD(pdata, XP_PROP_0);
>> + pdata->pp1 = XP_IOREAD(pdata, XP_PROP_1);
>> + pdata->pp2 = XP_IOREAD(pdata, XP_PROP_2);
>> + pdata->pp3 = XP_IOREAD(pdata, XP_PROP_3);
>> + pdata->pp4 = XP_IOREAD(pdata, XP_PROP_4);
>> +
>
> <...>
>
prev parent reply other threads:[~2024-01-09 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-05 11:32 Venkat Kumar Ande
2024-01-08 9:10 ` Sebastian, Selwin
2024-01-10 15:56 ` Ferruh Yigit
2024-01-09 10:35 ` Ferruh Yigit
2024-01-09 11:14 ` Ande, Venkat Kumar
2024-01-09 18:07 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c62995c6-0ddc-4656-8eac-3eeb94ad1c29@amd.com \
--to=ferruh.yigit@amd.com \
--cc=Selwin.Sebastian@amd.com \
--cc=VenkatKumar.Ande@amd.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).