From: "Singh, Aman Deep" <aman.deep.singh@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] devtools/cocci: update cocci for ethdev namespace
Date: Fri, 11 Feb 2022 13:37:38 +0530 [thread overview]
Message-ID: <c6d94df4-47fa-8435-e4da-89ca2d4c421e@intel.com> (raw)
In-Reply-To: <1843605.IobQ9Gjlxr@thomas>
[-- Attachment #1: Type: text/plain, Size: 1762 bytes --]
On 2/10/2022 9:00 PM, Thomas Monjalon wrote:
> 10/02/2022 14:26, Singh, Aman Deep:
>> On 2/4/2022 1:17 PM, Thomas Monjalon wrote:
>>> 04/02/2022 07:13, Singh, Aman Deep:
>>>> Hi Thomas
>>>>
>>>> On 2/3/2022 2:31 AM, Thomas Monjalon wrote:
>>>>> 23/01/2022 18:20, Aman Singh:
>>>>>> Added two specific exceptions for ETH_SPEED_10G
>>>>>> and ETH_SPEED_25G to avoid there name change.
>>>>>> Added check for ETH_TUNNEL_FILTER and ETH_RSS_RETA
>>>>> Please could you explain why?
>>>> These two macro's ETH_SPEED_10G & ETH_SPEED_25G are used by ifpga
>>>> driver and script should no change these.
>>>> There are multiple ETH_SPEED_NUM_xxx macro that need to be changed
>>>> to RTE_ETH_SPEED_NUM_xxx. So added above two as specific exceptions.
>>> Why doing this exception? What is special with ifpga?
>> These two macro's are defined in 'ifpga/base/opae_eth_group.h'
>> we don't intend to change these. Target is ethdev namespace only.
> So we will miss future use of a deprecated macro
> because ifpga is redefining it?
> I think it is a wrong approach.
> We should not make any exception in the check.
> Instead we can just ignore the warning for ifpga.
Actually ifpga is not redefining these two macro's ETH_SPEED_10G & ETH_SPEED_25G,
they are unique to it. Only there prefix, matches with ethdev macro's
ETH_SPEED_NUM_xxx, which caused coccinelle script to modify these to
RTE_ETH_SPEED_10G & RTE_ETH_SPEED_25G. So just avoiding it by this change.
>
>>>> The other two patterns ETH_TUNNEL_FILTER & ETH_RSS_RETA were missed before.
>>>> The script should change these to RTE_ETH_TUNNEL_FILTER & RTE_ETH_RSS_RETA
>>> The explanations should be part of the commit log please.
>> Sure, if this explanation is fine? Will update in next version.
> Yes thanks.
>
>
[-- Attachment #2: Type: text/html, Size: 3333 bytes --]
next prev parent reply other threads:[~2022-02-11 8:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-23 17:20 Aman Singh
2022-02-02 21:01 ` Thomas Monjalon
2022-02-04 6:13 ` Singh, Aman Deep
2022-02-04 7:47 ` Thomas Monjalon
2022-02-10 13:26 ` Singh, Aman Deep
2022-02-10 15:30 ` Thomas Monjalon
2022-02-11 8:07 ` Singh, Aman Deep [this message]
2022-02-11 17:28 ` Thomas Monjalon
2022-02-15 18:51 ` Singh, Aman Deep
2022-02-15 22:17 ` Thomas Monjalon
2022-02-17 6:34 ` Singh, Aman Deep
2022-03-07 14:27 ` [PATCH v3] " Aman Singh
2022-03-08 13:34 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6d94df4-47fa-8435-e4da-89ca2d4c421e@intel.com \
--to=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).