DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, dev@dpdk.org
Cc: Yuanhan Liu <yliu@fridaylinux.org>
Subject: Re: [dpdk-dev] [PATCH 0/8] vhost: input validation enhancements
Date: Tue, 6 Feb 2018 10:32:45 +0100	[thread overview]
Message-ID: <c6ec1baa-82e1-bea2-0c24-9a94c2978d24@redhat.com> (raw)
In-Reply-To: <20180205121642.26428-1-stefanha@redhat.com>

Hi Stefan,

On 02/05/2018 01:16 PM, Stefan Hajnoczi wrote:
> This patch series addresses missing input validation that I came across when
> reviewing vhost_user.c.
> 
> The first patch explains the security model and the rest fixes places with
> missing checks.
> 
> Now is a good time to discuss the security model if anyone disagrees or has
> questions about what Patch 1 says.

Thanks for the series, I agree validating vhost-user inputs is
necessary.

I'll go through the series, but it will be only for v18.05, as we are
close now to v18.02 release.

Maxime

> Stefan Hajnoczi (8):
>    vhost: add security model documentation to vhost_user.c
>    vhost: avoid enum fields in VhostUserMsg
>    vhost: validate untrusted memory.nregions field
>    vhost: clear out unused SCM_RIGHTS file descriptors
>    vhost: reject invalid log base mmap_offset values
>    vhost: fix msg->payload union typo in vhost_user_set_vring_addr()
>    vhost: validate virtqueue size
>    vhost: check for memory_size + mmap_offset overflow
> 
>   lib/librte_vhost/vhost_user.h |  4 +--
>   lib/librte_vhost/socket.c     |  8 +++++-
>   lib/librte_vhost/vhost_user.c | 57 +++++++++++++++++++++++++++++++++++++++++--
>   3 files changed, 64 insertions(+), 5 deletions(-)
> 

  parent reply	other threads:[~2018-02-06  9:32 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-05 12:16 Stefan Hajnoczi
2018-02-05 12:16 ` [dpdk-dev] [PATCH 1/8] vhost: add security model documentation to vhost_user.c Stefan Hajnoczi
2018-02-06 13:26   ` Kovacevic, Marko
     [not found]     ` <20180206142235.GB13343@stefanha-x1.localdomain>
2018-02-06 15:39       ` Kovacevic, Marko
2018-02-07 16:10       ` Mcnamara, John
2018-02-07 16:18         ` Maxime Coquelin
2018-02-07 17:23           ` Mcnamara, John
2018-02-05 12:16 ` [dpdk-dev] [PATCH 2/8] vhost: avoid enum fields in VhostUserMsg Stefan Hajnoczi
2018-02-06  9:47   ` Maxime Coquelin
2018-02-05 12:16 ` [dpdk-dev] [PATCH 3/8] vhost: validate untrusted memory.nregions field Stefan Hajnoczi
2018-02-05 12:16 ` [dpdk-dev] [PATCH 4/8] vhost: clear out unused SCM_RIGHTS file descriptors Stefan Hajnoczi
2018-02-05 12:16 ` [dpdk-dev] [PATCH 5/8] vhost: reject invalid log base mmap_offset values Stefan Hajnoczi
2018-02-05 12:16 ` [dpdk-dev] [PATCH 6/8] vhost: fix msg->payload union typo in vhost_user_set_vring_addr() Stefan Hajnoczi
2018-02-05 12:16 ` [dpdk-dev] [PATCH 7/8] vhost: validate virtqueue size Stefan Hajnoczi
2018-02-05 12:16 ` [dpdk-dev] [PATCH 8/8] vhost: check for memory_size + mmap_offset overflow Stefan Hajnoczi
2018-02-06  9:32 ` Maxime Coquelin [this message]
2018-02-06 10:01 ` [dpdk-dev] [PATCH 0/8] vhost: input validation enhancements Maxime Coquelin
2018-02-19 13:52 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6ec1baa-82e1-bea2-0c24-9a94c2978d24@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stefanha@redhat.com \
    --cc=yliu@fridaylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).