From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v8 00/15] common linkstatus functions
Date: Fri, 16 Mar 2018 10:31:04 +0000 [thread overview]
Message-ID: <c700e3e7-7c28-81e7-dd71-476e146722e0@intel.com> (raw)
In-Reply-To: <58d25cba-6586-71c6-78c0-a4e200c0f431@intel.com>
On 3/15/2018 5:38 PM, Ferruh Yigit wrote:
> On 1/26/2018 2:01 AM, Stephen Hemminger wrote:
>> While writing hyper-v driver, noticed a lot of unnecessary
>> duplication of code in drivers for handling the eth_dev link status
>> information. While consolidating this, it also became obvious that
>> some drivers behave differently for no good reason.
>>
>> It also was a good chance to introduce atomic exchange primitives
>> in EAL because there are other places using cmpset where not
>> necessary (such as bonding).
>>
>> Mostly only compile tested only, don't have all of the hardware
>> available (except ixgbe and virtio) to test.
>>
>> v8
>> - fix typo in 32bit exchange
>> - fix build of dpaa2
>> - go back to same return value as original code
>> - reduce number of lines changed
>>
>> v7
>> - add exchange functions for PPC64
>> - move linkstatus helpers to rte_ethdev_driver
>> - rebase to 18.02
>>
>> Stephen Hemminger (15):
>> eal: introduce atomic exchange operation
>> ethdev: add linkstatus get/set helper functions
>> net/virtio: use eth_linkstatus_set
>> net/vmxnet3: use rte_eth_linkstatus_set
>> net/dpaa2: use rte_eth_linkstatus_set
>> net/nfp: use rte_eth_linkstatus functions
>> net/e1000: use rte_eth_linkstatus helpers
>> net/ixgbe: use rte_eth_linkstatus functions
>> net/sfc: use new rte_eth_linkstatus functions
>> net/i40e: use rte_eth_linkstatus functions
>> net/liquidio: use rte_eth_linkstatus_set
>> net/thunderx: use rte_eth_linkstatus_set
>> net/szedata: use _rte_eth_linkstatus_set
>> net/octeontx: use rte_eth_linkstatus_set
>> net/enic: use rte_eth_linkstatus_set
>
> For series
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Series applied to dpdk-next-net/master, thanks.
(Need to resolve some conflicts, specially in i40e and vmxnet3, please verify
final patches.)
prev parent reply other threads:[~2018-03-16 10:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 2:01 Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 01/15] eal: introduce atomic exchange operation Stephen Hemminger
2018-01-26 17:14 ` Thomas Monjalon
2018-01-26 17:24 ` Bruce Richardson
2018-01-26 21:54 ` Stephen Hemminger
2018-01-29 9:51 ` Bruce Richardson
2018-01-26 17:59 ` Ananyev, Konstantin
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 02/15] ethdev: add linkstatus get/set helper functions Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 03/15] net/virtio: use eth_linkstatus_set Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 04/15] net/vmxnet3: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 05/15] net/dpaa2: " Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 06/15] net/nfp: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 07/15] net/e1000: use rte_eth_linkstatus helpers Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 08/15] net/ixgbe: use rte_eth_linkstatus functions Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 09/15] net/sfc: use new " Stephen Hemminger
2018-01-26 6:31 ` Andrew Rybchenko
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 10/15] net/i40e: use " Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 11/15] net/liquidio: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 12/15] net/thunderx: " Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 13/15] net/szedata: use _rte_eth_linkstatus_set Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 14/15] net/octeontx: use rte_eth_linkstatus_set Stephen Hemminger
2018-01-26 2:01 ` [dpdk-dev] [PATCH v8 15/15] net/enic: " Stephen Hemminger
2018-03-15 17:38 ` [dpdk-dev] [PATCH v8 00/15] common linkstatus functions Ferruh Yigit
2018-03-16 10:31 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c700e3e7-7c28-81e7-dd71-476e146722e0@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).