From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Rosen Xu <rosen.xu@intel.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com
Subject: Re: [dpdk-dev] [PATCH v5] app/testpmd: add IFPGA AFU register access function
Date: Thu, 20 Dec 2018 12:57:37 +0000 [thread overview]
Message-ID: <c7461ea9-76e1-a997-cb06-f365a98312c6@intel.com> (raw)
In-Reply-To: <1545132605-179951-1-git-send-email-rosen.xu@intel.com>
On 12/18/2018 11:30 AM, Rosen Xu wrote:
> @@ -11,6 +11,7 @@
>
> #include <rte_bus_pci.h>
> #include <rte_gro.h>
> #include <rte_gso.h>
> +#include <rte_bus_ifpga.h>
This adds dependency to ifpga for testpmd.
What happen if ifpga is disabled? Will testpmd build fail?
Is there a way to prevent this dependency?
If not I think it should be added with compile time checks, as some drivers did.
next prev parent reply other threads:[~2018-12-20 12:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 12:16 [dpdk-dev] [PATCH] app/test-pmd: add IFPGA AFU register read/write access for testpmd Rosen Xu
2018-12-07 10:24 ` Iremonger, Bernard
2018-12-14 1:16 ` Xu, Rosen
2018-12-14 1:14 ` [dpdk-dev] [PATCH v2] " Rosen Xu
2018-12-14 10:18 ` Iremonger, Bernard
2018-12-17 12:17 ` Xu, Rosen
2018-12-14 17:37 ` Pattan, Reshma
2018-12-17 12:16 ` Xu, Rosen
2018-12-17 12:29 ` [dpdk-dev] [PATCH v3] app/test-pmd: add IFPGA AFU register access fuction " Rosen Xu
2018-12-17 12:56 ` [dpdk-dev] [PATCH v4] app/test-pmd: add IFPGA AFU register access function " Rosen Xu
2018-12-18 10:21 ` Iremonger, Bernard
2018-12-18 11:32 ` Xu, Rosen
2018-12-18 11:30 ` [dpdk-dev] [PATCH v5] app/testpmd: add IFPGA AFU register access function Rosen Xu
2018-12-18 18:12 ` Iremonger, Bernard
2018-12-20 8:58 ` Ferruh Yigit
2018-12-20 10:48 ` Xu, Rosen
2018-12-20 14:22 ` Ferruh Yigit
2019-01-02 6:20 ` Xu, Rosen
2018-12-20 12:57 ` Ferruh Yigit [this message]
2019-01-02 6:19 ` [dpdk-dev] [PATCH v6] " Rosen Xu
2019-01-08 15:28 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c7461ea9-76e1-a997-cb06-f365a98312c6@intel.com \
--to=ferruh.yigit@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=rosen.xu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).