From: Radu Nicolau <radu.nicolau@intel.com>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Pattan, Reshma" <reshma.pattan@intel.com>,
"Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Jain, Deepak K" <deepak.k.jain@intel.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Azarewicz, PiotrX T" <piotrx.t.azarewicz@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000
Date: Tue, 20 Jun 2017 12:38:12 +0100 [thread overview]
Message-ID: <c8cc74c2-3198-5e52-346e-1a929a3a0aec@intel.com> (raw)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5BBD53@shsmsx102.ccr.corp.intel.com>
Hi,
On 5/23/2017 6:53 AM, Lu, Wenzhuo wrote:
> Hi Michal,
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pattan, Reshma
>> Sent: Tuesday, May 23, 2017 12:35 AM
>> To: Jastrzebski, MichalX K; dev@dpdk.org
>> Cc: Jain, Deepak K; Van Haaren, Harry; Azarewicz, PiotrX T
>> Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB and
>> EtherLike-MIB for e1000
>>
>> Hi,
>>
>> Can you add the description to the commit message, describing what has
>> been done.
>>
>> General doubt I have , I see all IF-MIB and Ether-Like-MIB attributes are
>> added as Xstats.
>> But most of IF-MIB attributes are not stats, instead they are information
>> about the interface/port.
>> So I guess such attributes should be displayed using separate method?
>> Everything being displayed as xstats might not be correct.
> The same question as Reshma. Seems most of the added parameters (if not all) are not stats.
Yes, they are indeed mostly information rather than actual statistics,
but I would say it's a better choice to have them in the xstats rather
than add a new API.
next prev parent reply other threads:[~2017-06-20 11:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-22 14:31 [dpdk-dev] [PATCH 0/3] drivers/net: add support for IF-MIB and EtherLike-MIB Michal Jastrzebski
2017-05-22 14:32 ` [dpdk-dev] [PATCH 1/3] drivers/net: add support for IF-MIB and EtherLike-MIB for e1000 Michal Jastrzebski
2017-05-22 16:16 ` Pattan, Reshma
2017-05-22 16:34 ` Pattan, Reshma
2017-05-23 5:53 ` Lu, Wenzhuo
2017-06-20 11:38 ` Radu Nicolau [this message]
2017-06-26 9:42 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2017-06-27 11:08 ` Ferruh Yigit
2017-06-27 11:21 ` Bruce Richardson
2017-06-27 11:36 ` Ferruh Yigit
2017-07-05 13:02 ` Pattan, Reshma
2017-06-27 22:26 ` Stephen Hemminger
2017-07-06 11:48 ` Pattan, Reshma
2017-07-19 10:40 ` Ferruh Yigit
2017-05-22 14:32 ` [dpdk-dev] [PATCH 2/3] drivers/net: add support for IF-MIB and EtherLike-MIB for i40e Michal Jastrzebski
2017-05-31 5:29 ` Xing, Beilei
2017-06-26 9:41 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2017-05-22 14:32 ` [dpdk-dev] [PATCH 3/3] drivers/net: add support for IF-MIB and EtherLike-MIB for ixgbe Michal Jastrzebski
2017-06-26 9:39 ` [dpdk-dev] [PATCH v2] " Radu Nicolau
2017-06-27 22:27 ` Stephen Hemminger
2017-05-22 16:11 ` [dpdk-dev] [PATCH 0/3] drivers/net: add support for IF-MIB and EtherLike-MIB Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8cc74c2-3198-5e52-346e-1a929a3a0aec@intel.com \
--to=radu.nicolau@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=michalx.k.jastrzebski@intel.com \
--cc=piotrx.t.azarewicz@intel.com \
--cc=reshma.pattan@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).