From: Garrett D'Amore <garrett@damore.org>
To: "dev@dpdk.org" <dev@dpdk.org>,
"Parthakumar Roy" <Parthakumar.Roy@ibm.com>
Subject: Re: meson option to customize RTE_PKTMBUF_HEADROOM patch
Date: Sat, 23 Mar 2024 13:51:25 -0700 [thread overview]
Message-ID: <c8e79fc1-c11e-48ab-8e23-7bc89d074ba3@Spark> (raw)
In-Reply-To: <DS0PR15MB55751C8B5830DE77981C8978E74D2@DS0PR15MB5575.namprd15.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 3143 bytes --]
So we right now (at WEKA) have a somewhat older version of DPDK that we have customized heavily, and I am going to to need to to make the headroom *dynamic* (passed in at run time, and per port.)
We have this requirement because we need payload to be at a specific offset, but have to deal with different header lengths for IPv4 and now IPv6.
My reason for pointing this out, is that I would dearly like if we could collaborate on this -- this change is going to touch pretty much every PMD (we don't need it on all of them as we only support a subset of PMDs, but its still a significant set.)
I'm not sure if anyone else has considered such a need -- this particular message caught my eye as I'm looking specifically in this area right now.
On Feb 15, 2024 at 11:02 AM -0800, Parthakumar Roy <Parthakumar.Roy@ibm.com>, wrote:
> Hello,
> Bruce Richardson suggested that I submit this patch - at IBM we needed to adjust the pkt_mbuf_headroom for our application to work. This is my first ever patch through a mailing list, I have only done it through Pull Requests before, so let me know if I need to correct something.
>
> Message:
> Add meson configuration option to adjust RTE_PKTMBUF_HEADROOM
>
> diff --git a/config/meson.build b/config/meson.build
> index 7cd375e991..43b765ade1 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -304,6 +304,7 @@ endforeach
> dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports'))
> dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('use_hpet'))
> dpdk_conf.set('RTE_ENABLE_TRACE_FP', get_option('enable_trace_fp'))
> +dpdk_conf.set('RTE_PKTMBUF_HEADROOM', get_option('pkt_mbuf_headroom'))
> # values which have defaults which may be overridden
> dpdk_conf.set('RTE_MAX_VFIO_GROUPS', 64)
> dpdk_conf.set('RTE_DRIVER_MEMPOOL_BUCKET_SIZE_KB', 64)
> diff --git a/config/rte_config.h b/config/rte_config.h
> index 7b8c85e948..a2bb4ea61b 100644
> --- a/config/rte_config.h
> +++ b/config/rte_config.h
> @@ -51,7 +51,6 @@
>
> /* mbuf defines */
> #define RTE_MBUF_DEFAULT_MEMPOOL_OPS "ring_mp_mc"
> -#define RTE_PKTMBUF_HEADROOM 128
>
> /* ether defines */
> #define RTE_MAX_QUEUES_PER_PORT 1024
> diff --git a/meson_options.txt b/meson_options.txt
> index 08528492f7..169fcc94c7 100644
> --- a/meson_options.txt
> +++ b/meson_options.txt
> @@ -36,6 +36,8 @@ option('machine', type: 'string', value: 'auto', description:
> 'Alias of cpu_instruction_set.')
> option('max_ethports', type: 'integer', value: 32, description:
> 'maximum number of Ethernet devices')
> +option('pkt_mbuf_headroom', type: 'integer', value: 128, description:
> + 'number of bytes skipped on Rx at the start of the packet buffer to leave room for additional packet headers')
> option('max_lcores', type: 'string', value: 'default', description:
> 'Set maximum number of cores/threads supported by EAL; "default" is different per-arch, "detect" detects the number of cores on the build machine.')
> option('max_numa_nodes', type: 'string', value: 'default', description:
>
[-- Attachment #2: Type: text/html, Size: 10985 bytes --]
next prev parent reply other threads:[~2024-03-23 20:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 19:02 Parthakumar Roy
2024-02-16 7:52 ` David Marchand
2024-02-20 14:57 ` [PATCH v2] build: make buffer headroom configurable Parthakumar Roy
2024-02-27 16:02 ` Bruce Richardson
2024-02-27 16:10 ` Morten Brørup
2024-03-06 16:45 ` Thomas Monjalon
2024-03-23 20:51 ` Garrett D'Amore [this message]
2024-03-25 10:01 ` meson option to customize RTE_PKTMBUF_HEADROOM patch Bruce Richardson
2024-03-25 17:20 ` Stephen Hemminger
2024-03-25 22:56 ` Garrett D'Amore
2024-03-26 8:05 ` Morten Brørup
2024-03-26 14:19 ` Garrett D'Amore
2024-03-26 15:06 ` Morten Brørup
2024-03-26 17:43 ` Garrett D'Amore
2024-03-26 20:35 ` Stephen Hemminger
2024-03-26 21:10 ` Garrett D'Amore
2024-03-26 16:14 ` Konstantin Ananyev
2024-03-26 17:44 ` Garrett D'Amore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c8e79fc1-c11e-48ab-8e23-7bc89d074ba3@Spark \
--to=garrett@damore.org \
--cc=Parthakumar.Roy@ibm.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).