From: "Hunt, David" <david.hunt@intel.com>
To: Reshma Pattan <reshma.pattan@intel.com>, <dev@dpdk.org>
Cc: Hamza Khan <hamza.khan@intel.com>, <alan.carew@intel.com>,
<stable@dpdk.org>, Reshma Pattan <reshma.pattan@intel.cm>
Subject: Re: [PATCH v4] examples/vm_power_manager: use safe version of list iterator
Date: Mon, 22 Aug 2022 12:29:44 +0100 [thread overview]
Message-ID: <c970fefc-d703-abd0-4cf0-b357bf29df8b@intel.com> (raw)
In-Reply-To: <20220822105855.6180-1-reshma.pattan@intel.com>
On 22/08/2022 11:58, Reshma Pattan wrote:
> From: Hamza Khan <hamza.khan@intel.com>
>
> Currently, when vm_power_manager exits, we are using a LIST_FOREACH
> macro to iterate over VM info structures while freeing them. This
> leads to use-after-free error. To address this, replace all usages of
> LIST_* with TAILQ_* macros, and use the RTE_TAILQ_FOREACH_SAFE macro
> to iterate and delete VM info structures.
>
> * The change is small and doesn’t affect other code
> * Testing was performed on the patch
>
> Fixes: e8ae9b662506 ("examples/vm_power: channel manager and monitor in host")
> Cc: alan.carew@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Hamza Khan <hamza.khan@intel.com>
> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
> Acked-by: Reshma Pattan <reshma.pattan@intel.cm>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> v4: fix header file inclusion
> ---
--snip--
Acked-by: David Hunt <david.hunt@intel.com>
next prev parent reply other threads:[~2022-08-22 11:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220601105455.166505-1-hamza.khan@intel.com>
2022-06-01 10:54 ` [PATCH 2/2] " Hamza Khan
2022-07-04 12:31 ` Hunt, David
2022-07-05 2:38 ` Li, WeiyuanX
2022-07-07 15:48 ` [PATCH v2] " Hamza Khan
2022-07-08 8:51 ` [PATCH v3] " Hamza Khan
2022-07-08 9:28 ` Hunt, David
2022-07-19 18:25 ` Pattan, Reshma
2022-08-22 10:58 ` [PATCH v4] " Reshma Pattan
2022-08-22 11:29 ` Hunt, David [this message]
2022-10-04 22:09 ` [PATCH v5] " Reshma Pattan
2022-10-05 10:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c970fefc-d703-abd0-4cf0-b357bf29df8b@intel.com \
--to=david.hunt@intel.com \
--cc=alan.carew@intel.com \
--cc=dev@dpdk.org \
--cc=hamza.khan@intel.com \
--cc=reshma.pattan@intel.cm \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).